Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: elim sign comparison in basedaemon #4368

Merged
merged 2 commits into from
Mar 22, 2022
Merged

fix: elim sign comparison in basedaemon #4368

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
212fa4b
fix: elim sign comparison in basedaemon
SchrodingerZhu Mar 21, 2022
64c0f5b
fix: typo in stacktrace tests
SchrodingerZhu Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/libdaemon/src/BaseDaemon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,8 @@ class SignalListener : public Poco::Runnable
if (already_printed_stack_trace)
return;

static constexpr int max_frames = 50;
int frames_size = 0;
static constexpr size_t max_frames = 50;
size_t frames_size = 0;
void * frames[max_frames];

#if USE_UNWIND
Expand Down