Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add read_tso as tracing id to DeltaTree engine #4287

Closed
JaySon-Huang opened this issue Mar 15, 2022 · 2 comments · Fixed by #4288
Closed

Add read_tso as tracing id to DeltaTree engine #4287

JaySon-Huang opened this issue Mar 15, 2022 · 2 comments · Fixed by #4288
Assignees
@JaySon-Huang @lidezhu
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@JaySon-Huang
Copy link
Contributor

Enhancement

After #3632, we introduce DynamicThreadPool to reuse threads for handling incoming tasks. Then the "thread_id" record in PageStorage snapshot become less useful.

Add a "tracing_id" to the PageStorage snapshot, and use "read_tso" as the "tracing_id", it is more useful for locating bugs.
@JaySon-Huang JaySon-Huang added the type/enhancement The issue or PR belongs to an enhancement. label Mar 15, 2022
This was referenced Mar 15, 2022
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Mar 18, 2022
@JaySon-Huang
Tracing: Add tracing_id to PageStorage snapshot (#4330)
706d7c3 
ref #4287
@JaySon-Huang JaySon-Huang mentioned this issue Mar 22, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 24, 2022
@JaySon-Huang
Logger: Refactor dmfile reader and add tracing_logger (#4379)
6301306 
ref #4287
ti-chi-bot pushed a commit that referenced this issue Apr 8, 2022
@JaySon-Huang
Tracing: Add read_tso as tracing id to PageStorage snapshot (#4288)
dec116f 
close #4287
@JaySon-Huang
Copy link
Contributor Author

Reopen since we need to show the tracing_id in TiDB system table information_schema.tiflash_tables

After #4288, we add three column in system.dt_tables. But they are not shown in the TiDB system table information_schema.tiflash_tables yet.

# debug show by using tiflash client
bash> ./tiflash client --host=127.0.0.1 --port=9000
tiflash> select * from system.dt_tables limit 1

One can refer to this PR for how to modify the TiDB information_schema.tiflash_tables system table pingcap/tidb#18092

@JaySon-Huang JaySon-Huang reopened this Apr 12, 2022
@JaySon-Huang JaySon-Huang changed the title Add read_tso as tracing id to PageStorage snapshot Add read_tso as tracing id to DeltaTree engine Apr 13, 2022
@breezewish breezewish mentioned this issue Sep 27, 2022
Merged
12 tasks
@breezewish
Copy link
Member

Corresponding fields has been added in pingcap/tidb#38191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaySon-Huang JaySon-Huang

@lidezhu lidezhu

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tracing: Add read_tso as tracing id to PageStorage snapshot JaySon-Huang/tiflash
3 participants
@breezewish @JaySon-Huang @lidezhu