-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner,executor,infoschema: add system tables tiflash_tables
and tiflash_segments
#18092
Conversation
tiflash_tables
and tiflash_segments
/run-unit-tests |
1 similar comment
/run-unit-tests |
/run-all-tests |
1 similar comment
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #18092 +/- ##
===========================================
Coverage 79.5852% 79.5852%
===========================================
Files 535 535
Lines 145679 145679
===========================================
Hits 115939 115939
Misses 20466 20466
Partials 9274 9274 |
9270649
to
a53bd37
Compare
/run-unit-test |
2 similar comments
/run-unit-test |
/run-unit-test |
@crazycs520 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crazycs520,Thanks for your review. |
/run-all-tests |
1 similar comment
/run-all-tests |
/merge |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #18536 |
What problem does this PR solve?
we can read tiflash storage stat from tidb for the ease of debug.
What is changed and how it works?
What's Changed: add two new system tables
tiflash_tables
andtiflash_segments
.How it Works: it uses etcd client to get http port of tiflash nodes, and then get data from corresponding tiflash system tables through the http port.
Related changes
Check List
Tests
Release note
tiflash_tables
andtiflash_segments