Logger: Refactor dmfile reader and add tracing_logger #4379

JaySon-Huang · 2022-03-22T09:16:19Z

What problem does this PR solve?

Issue Number: ref #4287

Problem Summary:

What is changed and how it works?

Introduce DMFileBlockInputStreamBuilder to prepare the params
Introduce DMFileBlockInputStreamBuilder::build() to init the member, open some files for IO, only after all success, then create DMFileBlockInputStream object
Prepare the tracing_logger API for DMFileReader and DMFilePackFilter to log down the message of rough set filter result while reading

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-03-22T09:16:21Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JinheLin
lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

JaySon-Huang · 2022-03-22T09:27:54Z

/run-all-tests

dbms/src/Storages/DeltaMerge/tests/gtest_dm_file.cpp

JaySon-Huang · 2022-03-22T09:41:25Z

/run-all-tests

JaySon-Huang · 2022-03-22T11:45:48Z

/run-all-tests

sre-bot · 2022-03-22T12:19:05Z

Coverage for changed files

Filename                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CPUAffinityManager.cpp                               193               130    32.64%          27                10    62.96%         228               122    46.49%         104                77    25.96%
Common/CPUAffinityManager.h                                   1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Functions/FunctionsString.cpp                              1212               368    69.64%         230                71    69.13%        2715               738    72.82%         742               282    61.99%
Server/DTTool/DTToolBench.cpp                               201               161    19.90%           5                 1    80.00%         318               206    35.22%          82                62    24.39%
Server/DTTool/DTToolInspect.cpp                             175                71    59.43%           3                 1    66.67%         155                81    47.74%          86                47    45.35%
Storages/DeltaMerge/ColumnFile/ColumnFileBig.cpp             68                 9    86.76%          12                 0   100.00%         167                20    88.02%          40                10    75.00%
Storages/DeltaMerge/DeltaMergeStore.cpp                    1328               467    64.83%          64                 5    92.19%        1904               429    77.47%         776               370    52.32%
Storages/DeltaMerge/File/DMFile.h                            80                 8    90.00%          57                 3    94.74%         120                20    83.33%          30                11    63.33%
Storages/DeltaMerge/File/DMFileBlockInputStream.cpp          12                 2    83.33%           2                 0   100.00%          42                 5    88.10%          12                 3    75.00%
Storages/DeltaMerge/File/DMFileBlockInputStream.h            16                 2    87.50%          16                 2    87.50%          53                 5    90.57%           0                 0         -
Storages/DeltaMerge/File/DMFilePackFilter.h                  98                 6    93.88%          12                 1    91.67%         190                 6    96.84%          70                 7    90.00%
Storages/DeltaMerge/File/DMFileReader.cpp                   203                11    94.58%          12                 0   100.00%         420                23    94.52%         146                17    88.36%
Storages/DeltaMerge/File/DMFileReader.h                       9                 0   100.00%           3                 0   100.00%           7                 0   100.00%           4                 0   100.00%
Storages/DeltaMerge/Segment.cpp                             637               189    70.33%          45                 4    91.11%        1119               264    76.41%         336               178    47.02%
Storages/DeltaMerge/StableValueSpace.cpp                     99                23    76.77%          15                 1    93.33%         272                64    76.47%          72                24    66.67%
Storages/DeltaMerge/tests/gtest_dm_file.cpp                3253              1073    67.02%          38                 2    94.74%        1337                 4    99.70%         958               418    56.37%
Storages/Page/V3/LogFile/LogReader.cpp                      145                12    91.72%           8                 0   100.00%         285                20    92.98%         122                18    85.25%
Storages/Page/V3/LogFile/LogReader.h                          3                 1    66.67%           3                 1    66.67%           3                 1    66.67%           0                 0         -
Storages/Page/V3/WAL/WALReader.cpp                           72                10    86.11%           9                 0   100.00%         174                15    91.38%          54                14    74.07%
Storages/Page/V3/tests/gtest_wal_log.cpp                   2523               370    85.33%          49                 0   100.00%         529                 1    99.81%         772               351    54.53%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                     10328              2913    71.80%         611               102    83.31%       10039              2024    79.84%        4406              1889    57.13%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17055      9588             43.78%    191780  97059        49.39%

full coverage report (for internal network access only)

JaySon-Huang · 2022-03-23T05:24:12Z

@lidezhu @JinheLin PTAL

dbms/src/Functions/FunctionsString.cpp

JinheLin · 2022-03-23T08:59:11Z

dbms/src/Storages/DeltaMerge/StableValueSpace.cpp

-                                                                                       true);
+            DMFileBlockInputStreamBuilder builder(context.db_context);
+            BlockInputStreamPtr data_stream = builder
+                                                  .setRowsThreshold(UINT64_MAX) // because we just read one pack at a time


For C++, I think std::numeric_limits<UInt64>::max() is better than UINT64_MAX.

dbms/src/Storages/DeltaMerge/File/DMFileBlockInputStream.cpp

dbms/src/Storages/DeltaMerge/File/DMFileReader.cpp

dbms/src/Storages/DeltaMerge/File/DMFileBlockInputStream.cpp

dbms/src/Storages/DeltaMerge/Segment.cpp

lidezhu

LGTM

Signed-off-by: JaySon-Huang <[email protected]>

JaySon-Huang · 2022-03-24T02:10:06Z

/merge

ti-chi-bot · 2022-03-24T02:10:06Z

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-03-24T02:10:12Z

This pull request has been accepted and is ready to merge.

Commit hash: 814e955

sre-bot · 2022-03-24T02:48:00Z

Coverage for changed files

Filename                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CPUAffinityManager.cpp                                   193               130    32.64%          27                10    62.96%         228               122    46.49%         104                77    25.96%
Common/CPUAffinityManager.h                                       1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Server/DTTool/DTToolBench.cpp                                   201               161    19.90%           5                 1    80.00%         318               206    35.22%          82                62    24.39%
Server/DTTool/DTToolInspect.cpp                                 175                71    59.43%           3                 1    66.67%         155                81    47.74%          86                47    45.35%
Storages/DeltaMerge/ColumnFile/ColumnFileBig.cpp                 68                 9    86.76%          12                 0   100.00%         167                20    88.02%          40                10    75.00%
Storages/DeltaMerge/DMVersionFilterBlockInputStream.cpp         103                11    89.32%           5                 0   100.00%         308                 5    98.38%          70                10    85.71%
Storages/DeltaMerge/DMVersionFilterBlockInputStream.h            79                12    84.81%          11                 1    90.91%         103                 1    99.03%          44                15    65.91%
Storages/DeltaMerge/DeltaMergeDefines.h                          26                 0   100.00%           8                 0   100.00%          28                 0   100.00%           2                 0   100.00%
Storages/DeltaMerge/DeltaMergeStore.cpp                        1328               467    64.83%          64                 5    92.19%        1904               429    77.47%         776               368    52.58%
Storages/DeltaMerge/File/DMFile.h                                80                 9    88.75%          57                 3    94.74%         120                21    82.50%          30                12    60.00%
Storages/DeltaMerge/File/DMFileBlockInputStream.cpp              12                 2    83.33%           2                 0   100.00%          43                 6    86.05%          12                 3    75.00%
Storages/DeltaMerge/File/DMFileBlockInputStream.h                16                 2    87.50%          16                 2    87.50%          53                 5    90.57%           0                 0         -
Storages/DeltaMerge/File/DMFilePackFilter.h                      98                 6    93.88%          12                 1    91.67%         190                 6    96.84%          70                 7    90.00%
Storages/DeltaMerge/File/DMFileReader.cpp                       203                11    94.58%          12                 0   100.00%         420                23    94.52%         146                17    88.36%
Storages/DeltaMerge/File/DMFileReader.h                           9                 0   100.00%           3                 0   100.00%           7                 0   100.00%           4                 0   100.00%
Storages/DeltaMerge/Segment.cpp                                 637               189    70.33%          45                 4    91.11%        1119               264    76.41%         336               178    47.02%
Storages/DeltaMerge/Segment.h                                    31                 4    87.10%          23                 3    86.96%          32                 4    87.50%           4                 2    50.00%
Storages/DeltaMerge/StableValueSpace.cpp                         99                23    76.77%          15                 1    93.33%         272                64    76.47%          72                24    66.67%
Storages/DeltaMerge/tests/gtest_dm_file.cpp                    3253              1073    67.02%          38                 2    94.74%        1337                 4    99.70%         958               418    56.37%
Storages/DeltaMerge/tests/gtest_dm_minmax_index.cpp            2093               377    81.99%          16                 0   100.00%         218                 0   100.00%         588               298    49.32%
Storages/DeltaMerge/tests/gtest_dm_segment.cpp                 3343               840    74.87%          37                 1    97.30%        1469                40    97.28%        1112               473    57.46%
Storages/DeltaMerge/tests/gtest_version_filter.cpp              939               134    85.73%           9                 0   100.00%         323                22    93.19%         290               134    53.79%
Storages/Page/V3/LogFile/LogReader.cpp                          145                12    91.72%           8                 0   100.00%         285                20    92.98%         122                18    85.25%
Storages/Page/V3/LogFile/LogReader.h                              3                 1    66.67%           3                 1    66.67%           3                 1    66.67%           0                 0         -
Storages/Page/V3/WAL/WALReader.cpp                               72                10    86.11%           9                 0   100.00%         174                15    91.38%          54                14    74.07%
Storages/Page/V3/tests/gtest_wal_log.cpp                       2523               370    85.33%          49                 0   100.00%         529                 1    99.81%         772               351    54.53%
Storages/StorageDeltaMerge.cpp                                  669               360    46.19%          56                29    48.21%        1290               762    40.93%         378               259    31.48%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                         16399              4284    73.88%         546                65    88.10%       11096              2122    80.88%        6152              2797    54.54%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17044      9571             43.85%    191835  97043        49.41%

full coverage report (for internal network access only)

JaySon-Huang · 2022-03-24T03:12:49Z

/merge

ti-chi-bot · 2022-03-24T03:12:50Z

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-03-24T03:12:55Z

This pull request has been accepted and is ready to merge.

Commit hash: 001479e

sre-bot · 2022-03-24T03:48:21Z

Coverage for changed files

Filename                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CPUAffinityManager.cpp                                   193               130    32.64%          27                10    62.96%         228               122    46.49%         104                77    25.96%
Common/CPUAffinityManager.h                                       1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Server/DTTool/DTToolBench.cpp                                   201               161    19.90%           5                 1    80.00%         318               206    35.22%          82                62    24.39%
Server/DTTool/DTToolInspect.cpp                                 175                71    59.43%           3                 1    66.67%         155                81    47.74%          86                47    45.35%
Storages/DeltaMerge/ColumnFile/ColumnFileBig.cpp                 68                 9    86.76%          12                 0   100.00%         167                20    88.02%          40                10    75.00%
Storages/DeltaMerge/DMVersionFilterBlockInputStream.cpp         103                11    89.32%           5                 0   100.00%         308                 5    98.38%          70                10    85.71%
Storages/DeltaMerge/DMVersionFilterBlockInputStream.h            79                12    84.81%          11                 1    90.91%         103                 1    99.03%          44                15    65.91%
Storages/DeltaMerge/DeltaMergeDefines.h                          26                 0   100.00%           8                 0   100.00%          28                 0   100.00%           2                 0   100.00%
Storages/DeltaMerge/DeltaMergeStore.cpp                        1328               476    64.16%          64                 5    92.19%        1904               433    77.26%         776               373    51.93%
Storages/DeltaMerge/File/DMFile.h                                80                 8    90.00%          57                 3    94.74%         120                20    83.33%          30                11    63.33%
Storages/DeltaMerge/File/DMFileBlockInputStream.cpp              12                 2    83.33%           2                 0   100.00%          43                 6    86.05%          12                 3    75.00%
Storages/DeltaMerge/File/DMFileBlockInputStream.h                16                 2    87.50%          16                 2    87.50%          53                 5    90.57%           0                 0         -
Storages/DeltaMerge/File/DMFilePackFilter.h                      98                 6    93.88%          12                 1    91.67%         190                 6    96.84%          70                 7    90.00%
Storages/DeltaMerge/File/DMFileReader.cpp                       203                11    94.58%          12                 0   100.00%         420                23    94.52%         146                17    88.36%
Storages/DeltaMerge/File/DMFileReader.h                           9                 0   100.00%           3                 0   100.00%           7                 0   100.00%           4                 0   100.00%
Storages/DeltaMerge/Segment.cpp                                 637               189    70.33%          45                 4    91.11%        1119               264    76.41%         336               178    47.02%
Storages/DeltaMerge/Segment.h                                    31                 4    87.10%          23                 3    86.96%          32                 4    87.50%           4                 2    50.00%
Storages/DeltaMerge/StableValueSpace.cpp                         99                23    76.77%          15                 1    93.33%         272                64    76.47%          72                24    66.67%
Storages/DeltaMerge/tests/gtest_dm_file.cpp                    3253              1073    67.02%          38                 2    94.74%        1337                 4    99.70%         958               418    56.37%
Storages/DeltaMerge/tests/gtest_dm_minmax_index.cpp            2093               377    81.99%          16                 0   100.00%         218                 0   100.00%         588               298    49.32%
Storages/DeltaMerge/tests/gtest_dm_segment.cpp                 3343               840    74.87%          37                 1    97.30%        1469                40    97.28%        1112               473    57.46%
Storages/DeltaMerge/tests/gtest_version_filter.cpp              939               134    85.73%           9                 0   100.00%         323                22    93.19%         290               134    53.79%
Storages/Page/V3/LogFile/LogReader.cpp                          145                12    91.72%           8                 0   100.00%         285                20    92.98%         122                18    85.25%
Storages/Page/V3/LogFile/LogReader.h                              3                 1    66.67%           3                 1    66.67%           3                 1    66.67%           0                 0         -
Storages/Page/V3/WAL/WALReader.cpp                               72                10    86.11%           9                 0   100.00%         174                15    91.38%          54                14    74.07%
Storages/Page/V3/tests/gtest_wal_log.cpp                       2523               370    85.33%          49                 0   100.00%         529                 1    99.81%         772               351    54.53%
Storages/StorageDeltaMerge.cpp                                  669               360    46.19%          56                29    48.21%        1290               762    40.93%         378               259    31.48%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                         16399              4292    73.83%         546                65    88.10%       11096              2125    80.85%        6152              2801    54.47%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17044      9571             43.85%    191835  97041        49.41%

full coverage report (for internal network access only)

sre-bot · 2022-03-24T04:43:08Z

Coverage for changed files

Filename                                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CPUAffinityManager.cpp                                   193               130    32.64%          27                10    62.96%         228               122    46.49%         104                77    25.96%
Common/CPUAffinityManager.h                                       1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Server/DTTool/DTToolBench.cpp                                   201               161    19.90%           5                 1    80.00%         318               206    35.22%          82                62    24.39%
Server/DTTool/DTToolInspect.cpp                                 175                71    59.43%           3                 1    66.67%         155                81    47.74%          86                47    45.35%
Storages/DeltaMerge/ColumnFile/ColumnFileBig.cpp                 68                 9    86.76%          12                 0   100.00%         167                20    88.02%          40                10    75.00%
Storages/DeltaMerge/DMVersionFilterBlockInputStream.cpp         103                11    89.32%           5                 0   100.00%         308                 5    98.38%          70                10    85.71%
Storages/DeltaMerge/DMVersionFilterBlockInputStream.h            79                12    84.81%          11                 1    90.91%         103                 1    99.03%          44                15    65.91%
Storages/DeltaMerge/DeltaMergeDefines.h                          26                 0   100.00%           8                 0   100.00%          28                 0   100.00%           2                 0   100.00%
Storages/DeltaMerge/DeltaMergeStore.cpp                        1328               476    64.16%          64                 5    92.19%        1904               433    77.26%         776               373    51.93%
Storages/DeltaMerge/File/DMFile.h                                80                 9    88.75%          57                 3    94.74%         120                21    82.50%          30                12    60.00%
Storages/DeltaMerge/File/DMFileBlockInputStream.cpp              12                 2    83.33%           2                 0   100.00%          43                 6    86.05%          12                 3    75.00%
Storages/DeltaMerge/File/DMFileBlockInputStream.h                16                 2    87.50%          16                 2    87.50%          53                 5    90.57%           0                 0         -
Storages/DeltaMerge/File/DMFilePackFilter.h                      98                 6    93.88%          12                 1    91.67%         190                 6    96.84%          70                 7    90.00%
Storages/DeltaMerge/File/DMFileReader.cpp                       203                10    95.07%          12                 0   100.00%         420                23    94.52%         146                16    89.04%
Storages/DeltaMerge/File/DMFileReader.h                           9                 0   100.00%           3                 0   100.00%           7                 0   100.00%           4                 0   100.00%
Storages/DeltaMerge/Segment.cpp                                 637               189    70.33%          45                 4    91.11%        1119               264    76.41%         336               178    47.02%
Storages/DeltaMerge/Segment.h                                    31                 4    87.10%          23                 3    86.96%          32                 4    87.50%           4                 2    50.00%
Storages/DeltaMerge/StableValueSpace.cpp                         99                23    76.77%          15                 1    93.33%         272                64    76.47%          72                24    66.67%
Storages/DeltaMerge/tests/gtest_dm_file.cpp                    3253              1073    67.02%          38                 2    94.74%        1337                 4    99.70%         958               418    56.37%
Storages/DeltaMerge/tests/gtest_dm_minmax_index.cpp            2093               377    81.99%          16                 0   100.00%         218                 0   100.00%         588               298    49.32%
Storages/DeltaMerge/tests/gtest_dm_segment.cpp                 3343               840    74.87%          37                 1    97.30%        1469                40    97.28%        1112               473    57.46%
Storages/DeltaMerge/tests/gtest_version_filter.cpp              939               134    85.73%           9                 0   100.00%         323                22    93.19%         290               134    53.79%
Storages/Page/V3/LogFile/LogReader.cpp                          145                12    91.72%           8                 0   100.00%         285                20    92.98%         122                18    85.25%
Storages/Page/V3/LogFile/LogReader.h                              3                 1    66.67%           3                 1    66.67%           3                 1    66.67%           0                 0         -
Storages/Page/V3/WAL/WALReader.cpp                               72                10    86.11%           9                 0   100.00%         174                15    91.38%          54                14    74.07%
Storages/Page/V3/tests/gtest_wal_log.cpp                       2523               370    85.33%          49                 0   100.00%         529                 1    99.81%         772               351    54.53%
Storages/StorageDeltaMerge.cpp                                  669               360    46.19%          56                29    48.21%        1290               762    40.93%         378               259    31.48%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                         16399              4292    73.83%         546                65    88.10%       11096              2126    80.84%        6152              2801    54.47%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17044      9571             43.85%    191826  97037        49.41%

full coverage report (for internal network access only)

ywqzzy · 2022-03-24T06:28:29Z

Fail to compile in UBuntu20.04.

@JaySon-Huang PTAL

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 22, 2022

JaySon-Huang mentioned this pull request Mar 22, 2022

Tracing: Add read_tso as tracing id to PageStorage snapshot #4288

Merged

12 tasks

JaySon-Huang requested review from lidezhu and flowbehappy March 22, 2022 09:17

JaySon-Huang requested a review from SchrodingerZhu March 22, 2022 09:28

JaySon-Huang commented Mar 22, 2022

View reviewed changes

dbms/src/Storages/DeltaMerge/tests/gtest_dm_file.cpp Show resolved Hide resolved

JaySon-Huang changed the title ~~Logger: Refactor dmfile reader and add tracing_logger~~ [WIP] Logger: Refactor dmfile reader and add tracing_logger Mar 22, 2022

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2022

JaySon-Huang mentioned this pull request Mar 22, 2022

Fix lint and remove unused member in FunctionsString #4382

Merged

12 tasks

JaySon-Huang changed the title ~~[WIP] Logger: Refactor dmfile reader and add tracing_logger~~ Logger: Refactor dmfile reader and add tracing_logger Mar 22, 2022

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2022

JinheLin reviewed Mar 23, 2022

View reviewed changes

lidezhu reviewed Mar 23, 2022

View reviewed changes

JaySon-Huang force-pushed the refactor_dmfile_reader branch 2 times, most recently from eb770fc to 915a081 Compare March 23, 2022 10:53

lidezhu approved these changes Mar 23, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022

JinheLin approved these changes Mar 23, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2022

JaySon-Huang added 2 commits March 24, 2022 10:05

Cleanup useless private member

85f055b

Signed-off-by: JaySon-Huang <[email protected]>

Add a builder for DMFile InputStream

ec50fc4

JaySon-Huang added 5 commits March 24, 2022 10:08

Add tracing logger for DMFileBlockInputStream

f248856

Fix bug cause by saving reference

e18a4a8

Replace UINT64_MAX by numeric_limits

9f7de32

Address comment

a734697

Compact memory layout for DMFileReader; sizeof(DMFileReader) 432 -> 416

814e955

JaySon-Huang force-pushed the refactor_dmfile_reader branch from f5a2bac to 814e955 Compare March 24, 2022 02:09

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022

Fix lint

001479e

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022

Merge branch 'master' into refactor_dmfile_reader

206854d

ti-chi-bot merged commit 6301306 into pingcap:master Mar 24, 2022

JaySon-Huang deleted the refactor_dmfile_reader branch March 24, 2022 04:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Logger: Refactor dmfile reader and add tracing_logger #4379

Logger: Refactor dmfile reader and add tracing_logger #4379

JaySon-Huang commented Mar 22, 2022

ti-chi-bot commented Mar 22, 2022 •

edited

Loading

JaySon-Huang commented Mar 22, 2022

JaySon-Huang commented Mar 22, 2022

JaySon-Huang commented Mar 22, 2022

sre-bot commented Mar 22, 2022

JaySon-Huang commented Mar 23, 2022

JinheLin Mar 23, 2022 •

edited

Loading

JaySon-Huang Mar 23, 2022

lidezhu left a comment

JaySon-Huang commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

sre-bot commented Mar 24, 2022

JaySon-Huang commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

sre-bot commented Mar 24, 2022

sre-bot commented Mar 24, 2022

ywqzzy commented Mar 24, 2022

Logger: Refactor dmfile reader and add tracing_logger #4379

Logger: Refactor dmfile reader and add tracing_logger #4379

Conversation

JaySon-Huang commented Mar 22, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Mar 22, 2022 • edited Loading

JaySon-Huang commented Mar 22, 2022

JaySon-Huang commented Mar 22, 2022

JaySon-Huang commented Mar 22, 2022

sre-bot commented Mar 22, 2022

Coverage for changed files

Coverage summary

JaySon-Huang commented Mar 23, 2022

JinheLin Mar 23, 2022 • edited Loading

Choose a reason for hiding this comment

JaySon-Huang Mar 23, 2022

Choose a reason for hiding this comment

lidezhu left a comment

Choose a reason for hiding this comment

JaySon-Huang commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

sre-bot commented Mar 24, 2022

Coverage for changed files

Coverage summary

JaySon-Huang commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

sre-bot commented Mar 24, 2022

Coverage for changed files

Coverage summary

sre-bot commented Mar 24, 2022

Coverage for changed files

Coverage summary

ywqzzy commented Mar 24, 2022

ti-chi-bot commented Mar 22, 2022 •

edited

Loading

JinheLin Mar 23, 2022 •

edited

Loading