expression: fix the wrong behavior of conv function

[qw4990]

What problem does this PR solve?

Issue Number: close #53505

Problem Summary: expression: fix the wrong behavior of conv function

What changed and how does it work?

When evaluating Constant, should always use Constant.EvalXXX() instead of accessing Constant.Value directly, otherwise there might be wrong result if it's a parameter (?).

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.6399%. Comparing base (04c66ee) to head (3cc35c4).
Report is 1118 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53681        +/-   ##
================================================
+ Coverage   74.4884%   74.6399%   +0.1515%     
================================================
  Files          1506       1506                
  Lines        357618     431174     +73556     
================================================
+ Hits         266384     321828     +55444     
- Misses        71857      89455     +17598     
- Partials      19377      19891       +514     

Flag	Coverage Δ
integration	49.2950% <40.0000%> (?)
unit	71.5093% <40.0000%> (-1.8579%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (-2.3014%)	⬇️
parser	∅ <ø> (∅)
br	50.4691% <ø> (+6.9056%)	⬆️

[qw4990]

/test check-dev2

[tiprow]

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-30 08:12:51.180194342 +0000 UTC m=+2936924.937329916: ☑️ agreed by time-and-fate.
• 2024-05-30 08:35:30.113746992 +0000 UTC m=+2938283.870882565: ☑️ agreed by XuHuaiyu.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/expression/OWNERS [XuHuaiyu]
• pkg/planner/OWNERS [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #53814.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #54354.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #54945.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #56889.