-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix the wrong behavior of conv
function (#53681)
#54945
expression: fix the wrong behavior of conv
function (#53681)
#54945
Conversation
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #54945 +/- ##
================================================
Coverage ? 71.1675%
================================================
Files ? 1465
Lines ? 422045
Branches ? 0
================================================
Hits ? 300359
Misses ? 101221
Partials ? 20465
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
1 similar comment
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #53681
What problem does this PR solve?
Issue Number: close #53505
Problem Summary: expression: fix the wrong behavior of
conv
functionWhat changed and how does it work?
When evaluating
Constant
, should always useConstant.EvalXXX()
instead of accessingConstant.Value
directly, otherwise there might be wrong result if it's a parameter (?
).Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.