expression: fix wrong result when convert float to unsigned

[guo-shaoge]

What problem does this PR solve?

Issue Number: close #41736

Problem Summary:

1. When compare int column with non int constant, will convert non int constant to int
2. This logic is used to check if underflow happens when convert to int, which requires we should set result as zero when convert X to unsigned int
3. But ConvertFloatToUint will not obey this requirement when AllowNegativeToUnsigned is disabled.

PS: what does AllowNegativeToUnsigned mean, check description here

What changed and how does it work?

Disable AllowNegativeToUnsigned when conversion happens when compare int column with non int constant.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

expression: fix wrong result when convert float to unsigned

[tiprow]

Hi @guo-shaoge. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7312%. Comparing base (c333f39) to head (d52311d).
Report is 11 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53590        +/-   ##
================================================
+ Coverage   72.3985%   74.7312%   +2.3326%     
================================================
  Files          1505       1507         +2     
  Lines        430553     436380      +5827     
================================================
+ Hits         311714     326112     +14398     
+ Misses        99509      90192      -9317     
- Partials      19330      20076       +746     

Flag	Coverage Δ
integration	49.6948% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	50.3790% <ø> (+9.0056%)	⬆️

[guo-shaoge]

/retest

[tiprow]

@guo-shaoge: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[SeaRise]

/cc @SeaRise

[SeaRise]

Sadly, this bug also appeared on tiflash

[guo-shaoge]

Sadly, this bug also appeared on tiflash

After this fix, tiflash will be ok. Because this fix happens during plan generation, so tilflash will receive correct plan after this fix. (verified using this fix and it's ok)

[guo-shaoge]

/retest

[tiprow]

@guo-shaoge: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-28 02:52:52.72958136 +0000 UTC m=+2744926.486716928: ☑️ agreed by SeaRise.
• 2024-05-28 05:05:52.516742324 +0000 UTC m=+2752906.273877897: ☑️ agreed by wshwsh12.

[wshwsh12]

/ok-to-test

[tiprow]

@guo-shaoge: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
fast_test_tiprow	d52311d	link	true	/test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[windtalker]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, windtalker, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [windtalker,wshwsh12]
• pkg/expression/OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #53608.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.3: #53609.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-5.4: #53610.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #53611.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #53612.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #53621.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #53622.