expression: fix wrong result when convert float to unsigned (#53590)

[ti-chi-bot]

This is an automated cherry-pick of #53590

What problem does this PR solve?

Issue Number: close #41736

Problem Summary:

1. When compare int column with non int constant, will convert non int constant to int
2. This logic is used to check if underflow happens when convert to int, which requires we should set result as zero when convert X to unsigned int
3. But ConvertFloatToUint will not obey this requirement when AllowNegativeToUnsigned is disabled.

PS: what does AllowNegativeToUnsigned mean, check description here

What changed and how does it work?

Disable AllowNegativeToUnsigned when conversion happens when compare int column with non int constant.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

expression: fix wrong result when convert float to unsigned

[windtalker]

I'm not sure if there is some multip-threads problems if you set this to true?

[guo-shaoge]

StatementContext is per query. Also this is during plan building. I think there is no concurrency issue.

[windtalker]

OK

[guo-shaoge]

/test unit-test

[tiprow]

@guo-shaoge: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@6a6455a). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.5     #53611   +/-   ##
================================================
  Coverage               ?   72.0138%           
================================================
  Files                  ?       1411           
  Lines                  ?     410528           
  Branches               ?          0           
================================================
  Hits                   ?     295637           
  Misses                 ?      95014           
  Partials               ?      19877           

Flag	Coverage Δ
unit	72.0138% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.8733% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	53.4707% <0.0000%> (?)

[windtalker]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [windtalker,wshwsh12]
• pkg/expression/OWNERS [windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-28 06:32:58.384020367 +0000 UTC m=+2758132.141155941: ☑️ agreed by wshwsh12.
• 2024-05-28 09:15:10.465180264 +0000 UTC m=+2767864.222315837: ☑️ agreed by windtalker.