Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: flush index records for local distributed sort #52641

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Apr 16, 2024

What problem does this PR solve?

Issue Number: close #52640

Problem Summary:

When temp-dir have no enough space, TiDB should flush index records to TiKV automatically. This has been implemented in the local ingest mode, but not in the distributed local sort mode.

What changed and how does it work?

Add flush check for local distributed sort according to the fix in #52178.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Before this PR, add index cannot finish.
    After this PR,
    image
    mysql> admin show ddl jobs 1;
    +--------+---------+------------+------------------------+--------------+-----------+----------+------------+---------------------+---------------------+---------------------+--------+
    | JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE               | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT  | CREATE_TIME         | START_TIME          | END_TIME            | STATE  |
    +--------+---------+------------+------------------------+--------------+-----------+----------+------------+---------------------+---------------------+---------------------+--------+
    |    111 | test    | sbtest1    | add index /* ingest */ | public       |         2 |      104 | 5000000000 | 2024-04-15 10:56:35 | 2024-04-15 10:56:35 | 2024-04-15 13:29:10 | synced |
    +--------+---------+------------+------------------------+--------------+-----------+----------+------------+---------------------+---------------------+---------------------+--------+
    1 row in set (0.28 sec)
    
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
Copy link

tiprow bot commented Apr 16, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta
Copy link
Contributor Author

/retest

@ywqzzy ywqzzy self-requested a review April 16, 2024 08:06
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 16, 2024
Copy link

tiprow bot commented Apr 16, 2024

@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Merging #52641 (ad1f379) into master (6660de7) will increase coverage by 1.9293%.
The diff coverage is 86.4864%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52641        +/-   ##
================================================
+ Coverage   72.3578%   74.2872%   +1.9293%     
================================================
  Files          1470       1471         +1     
  Lines        427134     427200        +66     
================================================
+ Hits         309065     317355      +8290     
+ Misses        98830      89989      -8841     
- Partials      19239      19856       +617     
Flag Coverage Δ
integration 48.5696% <86.4864%> (?)
unit 71.1945% <58.1081%> (-0.0547%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7325% <ø> (+8.6425%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 16, 2024
Copy link

ti-chi-bot bot commented Apr 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-16 08:18:44.520057294 +0000 UTC m=+326143.631103743: ☑️ agreed by ywqzzy.
  • 2024-04-16 10:07:14.881201007 +0000 UTC m=+332653.992247453: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit 924e7bf into pingcap:master Apr 16, 2024
21 of 23 checks passed
Copy link

ti-chi-bot bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Benjamin2037 Benjamin2037 added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Apr 16, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #52649.

@tangenta tangenta added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 10, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 10, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53146.

tangenta added a commit to ti-chi-bot/tidb that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add index with distributed local sort does not trigger import
6 participants