-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: flush index records for local distributed sort (#52641) #52649
ddl: flush index records for local distributed sort (#52641) #52649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #52649 +/- ##
================================================
Coverage ? 72.2562%
================================================
Files ? 1468
Lines ? 426939
Branches ? 0
================================================
Hits ? 308490
Misses ? 99150
Partials ? 19299
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
This is an automated cherry-pick of #52641
What problem does this PR solve?
Issue Number: close #52640
Problem Summary:
When temp-dir have no enough space, TiDB should flush index records to TiKV automatically. This has been implemented in the local ingest mode, but not in the distributed local sort mode.
What changed and how does it work?
Add flush check for local distributed sort according to the fix in #52178.
Check List
Tests
Before this PR, add index cannot finish.
After this PR,
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.