Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: flush index records for local distributed sort (#52641) #52649

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52641

What problem does this PR solve?

Issue Number: close #52640

Problem Summary:

When temp-dir have no enough space, TiDB should flush index records to TiKV automatically. This has been implemented in the local ingest mode, but not in the distributed local sort mode.

What changed and how does it work?

Add flush check for local distributed sort according to the fix in #52178.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Before this PR, add index cannot finish.
    After this PR,
    image
    mysql> admin show ddl jobs 1;
    +--------+---------+------------+------------------------+--------------+-----------+----------+------------+---------------------+---------------------+---------------------+--------+
    | JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE               | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT  | CREATE_TIME         | START_TIME          | END_TIME            | STATE  |
    +--------+---------+------------+------------------------+--------------+-----------+----------+------------+---------------------+---------------------+---------------------+--------+
    |    111 | test    | sbtest1    | add index /* ingest */ | public       |         2 |      104 | 5000000000 | 2024-04-15 10:56:35 | 2024-04-15 10:56:35 | 2024-04-15 13:29:10 | synced |
    +--------+---------+------------+------------------------+--------------+-----------+----------+------------+---------------------+---------------------+---------------------+--------+
    1 row in set (0.28 sec)
    
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 16, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 16, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 16, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 16, 2024
Copy link

ti-chi-bot bot commented Apr 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-16 14:36:07.309708414 +0000 UTC m=+348786.420754861: ☑️ agreed by Benjamin2037.
  • 2024-04-16 14:42:51.073133901 +0000 UTC m=+349190.184180349: ☑️ agreed by lance6716.

Copy link

ti-chi-bot bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.1@90ad4f5). Click here to learn what that means.
The diff coverage is 58.1081%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #52649   +/-   ##
================================================
  Coverage               ?   72.2562%           
================================================
  Files                  ?       1468           
  Lines                  ?     426939           
  Branches               ?          0           
================================================
  Hits                   ?     308490           
  Misses                 ?      99150           
  Partials               ?      19299           
Flag Coverage Δ
unit 71.1254% <58.1081%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.0929% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 5ccadf8 into pingcap:release-8.1 Apr 16, 2024
18 checks passed
@tangenta tangenta added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. and removed needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 10, 2024
ti-chi-bot added a commit to ti-chi-bot/tidb that referenced this pull request May 10, 2024
@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created to branch release-7.5: #53145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants