Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: flush index records for local distributed sort (#52641) #53146

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52641

What problem does this PR solve?

Issue Number: close #52640

Problem Summary:

When temp-dir have no enough space, TiDB should flush index records to TiKV automatically. This has been implemented in the local ingest mode, but not in the distributed local sort mode.

What changed and how does it work?

Add flush check for local distributed sort according to the fix in #52178.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Before this PR, add index cannot finish.
    After this PR,
    image
    mysql> admin show ddl jobs 1;
    +--------+---------+------------+------------------------+--------------+-----------+----------+------------+---------------------+---------------------+---------------------+--------+
    | JOB_ID | DB_NAME | TABLE_NAME | JOB_TYPE               | SCHEMA_STATE | SCHEMA_ID | TABLE_ID | ROW_COUNT  | CREATE_TIME         | START_TIME          | END_TIME            | STATE  |
    +--------+---------+------------+------------------------+--------------+-----------+----------+------------+---------------------+---------------------+---------------------+--------+
    |    111 | test    | sbtest1    | add index /* ingest */ | public       |         2 |      104 | 5000000000 | 2024-04-15 10:56:35 | 2024-04-15 10:56:35 | 2024-04-15 13:29:10 | synced |
    +--------+---------+------------+------------------------+--------------+-----------+----------+------------+---------------------+---------------------+---------------------+--------+
    1 row in set (0.28 sec)
    
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 10, 2024
@tangenta tangenta force-pushed the cherry-pick-52641-to-release-7.5 branch from b20489c to 0442470 Compare May 10, 2024 01:49
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 10, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 10, 2024
@ywqzzy
Copy link
Contributor

ywqzzy commented May 10, 2024

/lgtm

Copy link

ti-chi-bot bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 10, 2024
Copy link

ti-chi-bot bot commented May 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-10 01:50:47.87313962 +0000 UTC m=+1186001.630275195: ☑️ agreed by tangenta.
  • 2024-05-10 01:54:30.56044209 +0000 UTC m=+1186224.317577662: ☑️ agreed by ywqzzy.

@hawkingrei
Copy link
Member

/retest

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 13.51351% with 64 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release-7.5@f907137). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #53146   +/-   ##
================================================
  Coverage               ?   72.0170%           
================================================
  Files                  ?       1411           
  Lines                  ?     409785           
  Branches               ?          0           
================================================
  Hits                   ?     295115           
  Misses                 ?      94842           
  Partials               ?      19828           
Flag Coverage Δ
unit 72.0170% <13.5135%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4236% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 12c763f into pingcap:release-7.5 May 10, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants