Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: concurrency init stats (#51403) #52261

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51403

What problem does this PR solve?

Issue Number: close #52102

Problem Summary:

What changed and how does it work?

Now we init stats by single goroutine. it is slow. so that we create concurrency init stats to speed up.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

before

[2024/03/26 08:08:59.917 +00:00] [INFO] [domain.go:2286] ["init stats info time"] [lite=true] ["take time"=797.217483ms]
[2024/03/26 08:42:35.866 +00:00] [INFO] [domain.go:2286] ["init stats info time"] [lite=false] ["take time"=1m17.384163872s]

after

[2024/03/26 08:25:43.158 +00:00] [INFO] [domain.go:2292] ["init stats info time"] [lite=true] ["take time"=646.48434ms]
[2024/03/26 08:39:04.435 +00:00] [INFO] [domain.go:2292] ["init stats info time"] [lite=false] ["take time"=28.20059188s]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Mar 31, 2024
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@a0a5e99). Click here to learn what that means.
The diff coverage is 79.2207%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #52261   +/-   ##
================================================
  Coverage               ?   71.9727%           
================================================
  Files                  ?       1409           
  Lines                  ?     409237           
  Branches               ?          0           
================================================
  Hits                   ?     294539           
  Misses                 ?      94862           
  Partials               ?      19836           
Flag Coverage Δ
unit 71.9727% <79.2207%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3399% <0.0000%> (?)

@easonn7
Copy link

easonn7 commented Apr 1, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, easonn7, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 1, 2024
Copy link

ti-chi-bot bot commented Apr 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 00:15:50.765240466 +0000 UTC m=+230212.292781013: ☑️ agreed by hawkingrei.
  • 2024-04-01 01:38:53.513779004 +0000 UTC m=+235195.041319550: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit 669748e into pingcap:release-7.5 Apr 1, 2024
17 of 18 checks passed
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants