-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: concurrency init stats #51403
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51403 +/- ##
=================================================
- Coverage 70.7412% 54.8222% -15.9190%
=================================================
Files 1486 1602 +116
Lines 439485 611505 +172020
=================================================
+ Hits 310897 335241 +24344
- Misses 109161 253067 +143906
- Partials 19427 23197 +3770
Flags with carried forward coverage won't be shown. Click here to find out more.
|
108e52b
to
6dcf0f8
Compare
6dcf0f8
to
f0f18aa
Compare
/retest |
ae6d76e
to
84f07f2
Compare
65d4441
to
160ab06
Compare
/retest |
1 similar comment
/retest |
160ab06
to
f7c441b
Compare
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
f7c441b
to
d2a8c22
Compare
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
@AilinKid: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc
Signed-off-by: Weizhen Wang <[email protected]>
/approve |
/retest |
// Worker is used to load stats concurrently. | ||
type Worker struct { | ||
taskFunc func(ctx context.Context, req *chunk.Chunk) error | ||
dealFunc func(is infoschema.InfoSchema, cache statstypes.StatsCache, iter *chunk.Iterator4Chunk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about creating a type alias to avoid copying this signature repeatedly?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, easonn7, hi-rustin, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-7.5 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #52102
Problem Summary:
What changed and how does it work?
Now we init stats by single goroutine. it is slow. so that we create concurrency init stats to speed up.
Check List
Tests
before
after
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.