Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Initialization of Statistics for 10k+ Tables via Concurrent Loading #52102

Closed
hawkingrei opened this issue Mar 26, 2024 · 0 comments · Fixed by #51403
Closed

Optimize Initialization of Statistics for 10k+ Tables via Concurrent Loading #52102

hawkingrei opened this issue Mar 26, 2024 · 0 comments · Fixed by #51403
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.

Comments

@hawkingrei
Copy link
Member

hawkingrei commented Mar 26, 2024 •
edited
Loading

Enhancement

The current implementation of the initialization process for statistics is observed to be inefficient when dealing with a large number of tables. The process is currently single-threaded, leading to slow performance as each table's statistics are loaded sequentially.

I propose that we refactor the init stats process to support concurrent loading of statistics. By leveraging Go's concurrency patterns, such as goroutines and channels, we can significantly reduce the time taken to initialize statistics by processing multiple tables in parallel.
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Mar 26, 2024
@hawkingrei hawkingrei changed the title Optimize Initialization of Statistics for 10k Tables via Concurrent Loading Optimize Initialization of Statistics for 10k+ Tables via Concurrent Loading Mar 26, 2024
@hawkingrei hawkingrei mentioned this issue Mar 26, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Mar 28, 2024
@hawkingrei
statistics: concurrency init stats (#51403)
ce2cf92 
close #52102
@ti-chi-bot ti-chi-bot mentioned this issue Mar 31, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label Apr 1, 2024
ti-chi-bot bot pushed a commit that referenced this issue Apr 1, 2024
@ti-chi-bot
statistics: concurrency init stats (#51403) (#52261)
669748e 
close #52102
hawkingrei pushed a commit to hawkingrei/tidb that referenced this issue Apr 1, 2024
@ti-chi-bot @hawkingrei
statistics: concurrency init stats (pingcap#51403) (pingcap#52261)
2cd930e 
close pingcap#52102
@hawkingrei hawkingrei mentioned this issue Apr 1, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 1, 2024
@hawkingrei
*: support concurrently init stats (#52273)
9a55a11 
ref #52102
@Ivy-YinSu Ivy-YinSu added the sig/planner SIG: Planner label Apr 22, 2024
This was referenced May 13, 2024
Merged
Merged
This was referenced May 13, 2024
Merged
Merged
@hawkingrei hawkingrei mentioned this issue Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

statistics: concurrency init stats hawkingrei/tidb
3 participants
@hawkingrei @Ivy-YinSu @ti-chi-bot