-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: add ru details in slow log and INFORMATION_SCHEMA.SLOW_QUERY #49067
Conversation
Hi @glorv. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
go.sum
Outdated
@@ -271,6 +271,10 @@ github.com/ghemawat/stream v0.0.0-20171120220530-696b145b53b9/go.mod h1:106OIgoo | |||
github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04= | |||
github.com/gin-contrib/sse v0.0.0-20190301062529-5545eab6dad3/go.mod h1:VJ0WA2NBN22VlZ2dKZQPAPnyWw5XTlK1KymzLKsr59s= | |||
github.com/gin-gonic/gin v1.4.0/go.mod h1:OW2EZn3DO8Ln9oIKOvM++LBO+5UPHJJDH72/q/3rZdM= | |||
github.com/glorv/client-go/v2 v2.0.1-0.20231130110809-812d6876b43f h1:pMnYb5jUkLB9QqXxitBtcg/8Hne+5oYTW9P9w3UN2Jo= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make bazel_prepare
and upload the dependencies.
/retest |
/test tiprow_fast_test |
@glorv: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49067 +/- ##
================================================
+ Coverage 71.0441% 71.5215% +0.4773%
================================================
Files 1368 1415 +47
Lines 402948 423474 +20526
================================================
+ Hits 286271 302875 +16604
- Misses 96736 101615 +4879
+ Partials 19941 18984 -957
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
1 similar comment
/retest |
test failure is caused by #49113 |
@nolouch @CabinfeverB @HuSharp PTAL |
@nolouch @HuSharp @CabinfeverB PTAL |
@yudongusa PTAL |
@easonn7 PTAL |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, easonn7, nolouch, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.6 from head ti-chi-bot:cherry-pick-49067-to-release-7.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-49067-to-release-7.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} |
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.6 from head ti-chi-bot:cherry-pick-49067-to-release-7.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-49067-to-release-7.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: ref #49318 close #42892
Problem Summary:
What changed and how does it work?
Add
Resource_group
,Request_unit_read
,Request_unit_write
andTime_queued_by_rc
in slow_log and INFORMATION_SCHEMA.SLOW_QUERY.NOTE: The three new fields are collected in client-go resourceControlInterceptor after tikv/client-go#1070
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.