infosync, helper: add caller ID to the PD HTTP client on the hot path #49134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
|
/cc @hawkingrei @zimulala |
JmPotato
force-pushed
the
init_pd_http_cli_caller_id
branch
from
a622e2e to
72a95d0
Compare
ti-chi-bot
bot
added
size/XXL
JmPotato
force-pushed
the
init_pd_http_cli_caller_id
branch
2 times, most recently
from
c216ab6 to
1b8869b
Compare
ti-chi-bot
bot
added
size/M
|
Wait for #49067 being merged. |
JmPotato
force-pushed
the
init_pd_http_cli_caller_id
branch
from
1b8869b to
26349c7
Compare
|
/retest |
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
init_pd_http_cli_caller_id
branch
from
26349c7 to
f7469c3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49134 +/- ##
================================================
+ Coverage 70.9870% 71.6244% +0.6374%
================================================
Files 1368 1417 +49
Lines 399790 417483 +17693
================================================
+ Hits 283799 299020 +15221
- Misses 96179 99647 +3468
+ Partials 19812 18816 -996
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zimulala
reviewed
Dec 14, 2023
zimulala
approved these changes
Dec 14, 2023
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
hawkingrei
approved these changes
Dec 14, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #35319, tikv/pd#7300.
Problem Summary:
Add caller ID to the PD HTTP client on the hot path.
What changed and how does it work?
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.