Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add ru details in slow log and INFORMATION_SCHEMA.SLOW_QUERY (#49067) #50881

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 1, 2024

This is an automated cherry-pick of #49067

What problem does this PR solve?

Issue Number: ref #49318 close #42892

Problem Summary:

What changed and how does it work?

Add Resource_group, Request_unit_read, Request_unit_write and Time_queued_by_rc in slow_log and INFORMATION_SCHEMA.SLOW_QUERY.

NOTE: The three new fields are collected in client-go resourceControlInterceptor after tikv/client-go#1070

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 1, 2024
Signed-off-by: nolouch <[email protected]>
@nolouch
Copy link
Member

nolouch commented Feb 18, 2024

/retest-required

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 18, 2024
@nolouch nolouch requested review from hawkingrei and glorv and removed request for hawkingrei February 18, 2024 09:10
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 18, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2024
Copy link

ti-chi-bot bot commented Feb 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-18 09:10:38.757186028 +0000 UTC m=+175527.504809136: ☑️ agreed by nolouch.
  • 2024-02-18 09:13:14.892471065 +0000 UTC m=+175683.640094174: ☑️ agreed by glorv.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@5ff5468). Click here to learn what that means.
The diff coverage is 85.3658%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #50881   +/-   ##
================================================
  Coverage               ?   72.1031%           
================================================
  Files                  ?       1403           
  Lines                  ?     408050           
  Branches               ?          0           
================================================
  Hits                   ?     294217           
  Misses                 ?      94142           
  Partials               ?      19691           
Flag Coverage Δ
unit 72.1031% <85.3658%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.3520% <0.0000%> (?)

@easonn7
Copy link

easonn7 commented Feb 18, 2024

/approve

Copy link

ti-chi-bot bot commented Feb 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, glorv, nolouch, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 18, 2024
@nolouch
Copy link
Member

nolouch commented Feb 18, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit b4a73d5 into pingcap:release-7.5 Feb 18, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants