Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: share etcd client from domain for autoid allocator (#46647) #48310

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46647

What problem does this PR solve?

Issue Number: close #46324

Problem Summary:

The autoid allocate service need a etcd client, we can create one and close it after use.
But every time infoschema reload, we need to create one...
A better solution is to share the etcd client in domain.Domain (also ddl.DDL)

What is changed and how it works?

Refactor the auto id parameter from kv.Store to autoid.Requirement
The autoid.Requirement now consists of a kv.Store and a clientv3.Client...
This change affect quite a lot packages, especially tools packages.

Check List

Tests

This is a code refactor so all the old tests should not be break.

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 6, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 6, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 21, 2023
@tiancaiamao tiancaiamao force-pushed the cherry-pick-46647-to-release-6.5 branch from 1e0fad1 to af05aec Compare November 24, 2023 14:25
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2023
@tiancaiamao
Copy link
Contributor

This cherry-pick also contains the changes from #48870
Because the master branch differs too much from this branch, the resolve conflict process is painful.
If I cherry-pick and merge the one by one, I have to resolve conflict twice, that would be painful x2

@tiancaiamao tiancaiamao requested a review from tangenta November 24, 2023 15:39
@tiancaiamao
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Nov 25, 2023

@tiancaiamao: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@5a6b36c). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #48310   +/-   ##
================================================
  Coverage               ?   73.6382%           
================================================
  Files                  ?       1087           
  Lines                  ?     349396           
  Branches               ?          0           
================================================
  Hits                   ?     257289           
  Misses                 ?      75594           
  Partials               ?      16513           

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2023
Copy link

ti-chi-bot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lcwangchao,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-27 01:50:28.960705909 +0000 UTC m=+801057.625932104: ☑️ agreed by lcwangchao.
  • 2023-11-27 02:54:15.184914349 +0000 UTC m=+804883.850140544: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit c2bea02 into pingcap:release-6.5 Nov 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants