Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd client leak when a table uses AUTO_ID_CACHE=1 and auto_increment #46324

Closed
D3Hunter opened this issue Aug 22, 2023 · 1 comment · Fixed by #46647
Closed

etcd client leak when a table uses AUTO_ID_CACHE=1 and auto_increment #46324

D3Hunter opened this issue Aug 22, 2023 · 1 comment · Fixed by #46647
Assignees
@tiancaiamao
Labels
affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 fixes-6.5.6 fixes-7.1.3 fixes-7.5.0 report/customer Customers have encountered this bug. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

nowhere close this etcd client

tidb/meta/autoid/autoid.go

Line 588 in 1769f3a

etcdCli, err := clientv3.New(clientv3.Config{

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

this code is introduced in tidb version >= 6.4.0
@D3Hunter D3Hunter added the type/bug The issue is confirmed as a bug. label Aug 22, 2023
@D3Hunter D3Hunter changed the title etcd client leak when using AUTO_ID_CACHE=1 etcd client leak when a table uses AUTO_ID_CACHE=1 and auto_increment Aug 22, 2023
@tiancaiamao tiancaiamao self-assigned this Aug 23, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Aug 23, 2023
@tiancaiamao tiancaiamao mentioned this issue Sep 4, 2023
Merged
12 tasks
@tiancaiamao tiancaiamao added affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 and removed may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Sep 5, 2023
@ti-chi-bot ti-chi-bot added the affects-7.5 This bug affects the 7.5.x(LTS) versions. label Oct 23, 2023
ti-chi-bot bot pushed a commit that referenced this issue Nov 6, 2023
@tiancaiamao
*: share etcd client from domain for autoid allocator (#46647)
4979e99 
close #46324
This was referenced Nov 6, 2023
Closed
Merged
Merged
@tiancaiamao tiancaiamao mentioned this issue Nov 6, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 7, 2023
@tiancaiamao
*: share etcd client from domain for autoid allocator #46647 (#48335)
a062330 
close #46324
ti-chi-bot bot pushed a commit that referenced this issue Nov 10, 2023
@ti-chi-bot
*: share etcd client from domain for autoid allocator (#46647) (#48309)
700beaf 
close #46324
@tiancaiamao tiancaiamao mentioned this issue Nov 24, 2023
Merged
13 tasks
@tiancaiamao
Copy link
Contributor

Ref #48869

tiancaiamao added a commit to ti-chi-bot/tidb that referenced this issue Nov 24, 2023
@tiancaiamao
*: share etcd client from domain for autoid allocator pingcap#46647 (p…
07dcfb0 
…ingcap#48335)

close pingcap#46324
ti-chi-bot bot pushed a commit that referenced this issue Nov 27, 2023
@ti-chi-bot
*: share etcd client from domain for autoid allocator (#46647) (#48310)
c2bea02 
close #46324
@hawkingrei hawkingrei mentioned this issue Nov 30, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 30, 2023
@tiancaiamao
ddl: fix 6.5.6 merge CI (#49049)
e30242b 
close #46324
tiancaiamao added a commit to ti-chi-bot/tidb that referenced this issue Dec 6, 2023
@tiancaiamao
*: share etcd client from domain for autoid allocator pingcap#46647 (p…
7727264 
…ingcap#48335)

close pingcap#46324
@tiancaiamao tiancaiamao added fixes-7.1.3 fixes-7.5.0 and removed affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Dec 8, 2023
@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiancaiamao tiancaiamao

Labels
affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 fixes-6.5.6 fixes-7.1.3 fixes-7.5.0 report/customer Customers have encountered this bug. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: share etcd client from domain for autoid allocator tiancaiamao/tidb
4 participants
@tiancaiamao @D3Hunter @jebter @ti-chi-bot