Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: share etcd client from domain for autoid allocator #46647 #48335

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #46324

Problem Summary:

The autoid allocate service need a etcd client, we can create one and close it after use.
But every time infoschema reload, we need to create one...
A better solution is to share the etcd client in domain.Domain (also ddl.DDL)

What is changed and how it works?

Refactor the auto id parameter from kv.Store to autoid.Requirement
The autoid.Requirement now consists of a kv.Store and a clientv3.Client...
This change affect quite a lot packages, especially tools packages.

Check List

Tests

This is a code refactor so all the old tests should not be break.

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 6, 2023
Copy link

tiprow bot commented Nov 6, 2023

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao tiancaiamao requested review from D3Hunter and tangenta and removed request for D3Hunter November 6, 2023 16:33
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1-20231106-v7.1.2@7654faa). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-7.1-20231106-v7.1.2     #48335   +/-   ##
================================================================
  Coverage                               ?   73.4309%           
================================================================
  Files                                  ?       1206           
  Lines                                  ?     377575           
  Branches                               ?          0           
================================================================
  Hits                                   ?     277257           
  Misses                                 ?      82620           
  Partials                               ?      17698           

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 7, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 7, 2023
Copy link

ti-chi-bot bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 7, 2023
Copy link

ti-chi-bot bot commented Nov 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-07 02:00:51.943156982 +0000 UTC m=+3523249.530267127: ☑️ agreed by GMHDBJD.
  • 2023-11-07 02:01:15.252374769 +0000 UTC m=+3523272.839484907: ☑️ agreed by lcwangchao.

@ti-chi-bot ti-chi-bot bot merged commit a062330 into pingcap:release-7.1-20231106-v7.1.2 Nov 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants