Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add the temporary table design proposal #24168

Merged
merged 3 commits into from
May 24, 2021
Merged

docs: add the temporary table design proposal #24168

merged 3 commits into from
May 24, 2021

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

The temporary table design proposal.

What is changed and how it works?

What's Changed:

How it Works:

Release note

  • No release note

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 20, 2021
@tiancaiamao tiancaiamao mentioned this pull request Apr 20, 2021
Closed
89 tasks
@tiancaiamao tiancaiamao mentioned this pull request Apr 21, 2021
Merged
@djshow832 djshow832 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2021
@tiancaiamao tiancaiamao mentioned this pull request Apr 22, 2021
Merged
@Howie59 Howie59 mentioned this pull request May 2, 2021
Merged
This was referenced May 8, 2021
Merged
Merged
@tiancaiamao tiancaiamao force-pushed the tmp-table-proposal branch from b27298c to dd41dfa Compare May 14, 2021 14:20
@tiancaiamao
Copy link
Contributor Author

PTAL @djshow832

@Howie59 Howie59 mentioned this pull request May 17, 2021
Merged
@djshow832 djshow832 added type/new-feature and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 18, 2021
@djshow832
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2021
@tisonkun
Copy link
Contributor

/cc @Howie59 @mmyj

@ti-chi-bot
Copy link
Member

@tisonkun: GitHub didn't allow me to request PR reviews from the following users: mmyj, Howie59.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Howie59 @mmyj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Howie59
Copy link
Contributor

Howie59 commented May 24, 2021

/LGTM

@ti-chi-bot
Copy link
Member

@Howie59: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mmyj
Copy link
Member

mmyj commented May 24, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • mmyj

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 24, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dd41dfa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 24, 2021
@ti-chi-bot
Copy link
Member

@tiancaiamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5acff63 into pingcap:master May 24, 2021
This was referenced May 24, 2021
Merged
Merged
Merged
This was referenced Jun 2, 2021
Merged
Merged
@djshow832 djshow832 mentioned this pull request Jun 7, 2021
Closed
1 task
@tiancaiamao tiancaiamao deleted the tmp-table-proposal branch June 15, 2021 02:53
This was referenced Jul 22, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@djshow832 djshow832 Awaiting requested review from djshow832

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tiancaiamao @CLAassistant @djshow832 @tisonkun @ti-chi-bot @Howie59 @mmyj