Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: add virtual columns compatibility for temporary table #25065

Merged
merged 15 commits into from
Jun 4, 2021
Merged

ddl: add virtual columns compatibility for temporary table #25065

merged 15 commits into from
Jun 4, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented Jun 2, 2021

What problem does this PR solve?

Issue Number: see #24168

What is changed and how it works?

Proposal: temporary table

What's Changed: add virtual columns compatibility for temporary table

Check List

Tests

  • Unit test

Release note

  • No release note

@Howie59
virtual columns
1a83dd9 
Signed-off-by: lihaowei <[email protected]>
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 2, 2021
djshow832
djshow832 reviewed Jun 3, 2021
View reviewed changes
ddl/ddl_api.go Outdated
if tbInfo.TempTableType != model.TempTableNone {
for _, column := range tbInfo.Columns {
if column.IsGenerated() && !column.GeneratedStored {
return ErrOptOnTemporaryTable.GenWithStackByArgs("virtual columns")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really unable to support virtual columns? Would you have a try?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's able to support it, we don't need to forbid it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i test it on my compute, if the column is virtual, it match the condition in line 1819. why don't need to forbid it?

@djshow832 djshow832 mentioned this pull request Jun 3, 2021
Closed
89 tasks
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ef3dc21

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 115dc66

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@djshow832
Copy link
Contributor

/merge

@djshow832
Copy link
Contributor

/run-all-tests

@ti-chi-bot
Copy link
Member

@Howie59: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4457ba8 into pingcap:master Jun 4, 2021
@Howie59 Howie59 deleted the virtual-columns branch June 7, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Howie59 @ti-chi-bot @djshow832 @tiancaiamao