Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove alter table lock to improve performance when importing large mount of tables #50105

Closed
D3Hunter opened this issue Jan 5, 2024 · 0 comments · Fixed by #50074
Closed

remove alter table lock to improve performance when importing large mount of tables #50105

D3Hunter opened this issue Jan 5, 2024 · 0 comments · Fixed by #50074
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. severity/moderate type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Jan 5, 2024 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

here we run alter table in serial(add in pingcap/tidb-lightning#87), we can run in parallel now and let tidb handle it

it's an enhancement, will make a bug to cp to older versions

tidb/br/pkg/lightning/importer/table_import.go

Line 954 in d11a559

rc.alterTableLock.Lock()

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement. severity/moderate affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Jan 5, 2024
@D3Hunter D3Hunter mentioned this issue Jan 5, 2024
Merged
13 tasks
@D3Hunter D3Hunter changed the title remove alter table lock to improve performance remove alter table lock to improve performance when importing large mount of tables Jan 5, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jan 5, 2024
@D3Hunter
lightning: remove alter table lock (#50074)
b13d1d0 
close #50105
@ti-chi-bot ti-chi-bot mentioned this issue Jan 5, 2024
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue Jan 5, 2024
@D3Hunter @ti-chi-bot
lightning: remove alter table lock (pingcap#50074)
c45d1e9 
close pingcap#50105
@ti-chi-bot ti-chi-bot mentioned this issue Jan 5, 2024
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue Jan 5, 2024
@D3Hunter @ti-chi-bot
lightning: remove alter table lock (pingcap#50074)
72a4ef2 
close pingcap#50105
@ti-chi-bot ti-chi-bot mentioned this issue Jan 5, 2024
Merged
13 tasks
AilinKid pushed a commit to AilinKid/tidb that referenced this issue Jan 17, 2024
@D3Hunter @AilinKid
lightning: remove alter table lock (pingcap#50074)
ac771df 
close pingcap#50105
@Ivy-YinSu Ivy-YinSu added the component/lightning This issue is related to Lightning of TiDB. label Jan 23, 2024
ti-chi-bot bot pushed a commit that referenced this issue Jan 24, 2024
@ti-chi-bot
lightning: remove alter table lock (#50074) (#50116)
7caa282 
close #50105
ti-chi-bot bot pushed a commit that referenced this issue Feb 2, 2024
@ti-chi-bot
lightning: remove alter table lock (#50074) (#50118)
630e995 
close #50105
ti-chi-bot bot pushed a commit that referenced this issue Feb 22, 2024
@ti-chi-bot
lightning: remove alter table lock (#50074) (#50117)
23052ef 
close #50105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. component/lightning This issue is related to Lightning of TiDB. severity/moderate type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lightning: remove alter table lock D3Hunter/tidb
2 participants
@D3Hunter @Ivy-YinSu