Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

restore: ensure the ALTER TABLE step is also serial #87

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented Nov 24, 2018

Prevent issue like TOOL-633

What problem does this PR solve?

Ensure the ALTER TABLE step is serial to prevent two DDL be executed concurrently which may cause TOOL-633.

What is changed and how it works?

Add a mutex around the ALTER TABLE step

Check List

Tests

Code changes

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

@sre-bot
Copy link

sre-bot commented Nov 24, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@kennytm
Copy link
Collaborator Author

kennytm commented Nov 24, 2018

/run-all-tests

@kennytm
Copy link
Collaborator Author

kennytm commented Nov 24, 2018

@GregoryIan PTAL

cc @winkyao

@IANTHEREAL
Copy link
Collaborator

LGTM

@kennytm kennytm added the status/LGT1 One reviewer already commented LGTM (LGTM1) label Nov 24, 2018
@kennytm

This comment has been minimized.

@iamxy
Copy link
Member

iamxy commented Nov 24, 2018

/ok-to-test

@iamxy
Copy link
Member

iamxy commented Nov 24, 2018

LGTM

@IANTHEREAL IANTHEREAL added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Nov 24, 2018
@kennytm kennytm merged commit 400ccdc into master Nov 24, 2018
@kennytm kennytm deleted the kennytm/lock-alter-table branch November 24, 2018 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants