Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiflash config after v5.4.0 (#4430) #4436

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 22, 2022

cherry-pick #4430 to release-1.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb-operator repo:
git pr https://github.com/pingcap/tidb-operator/pull/4436

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb-operator.git pr/4436:release-1.3-1eb8baa4f2b2

What problem does this PR solve?

Close #4434
Close #4435

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test

  • E2E test

  • Manual test

    • Deploy operator and v5.4.0 cluster, check the result of using TiFlash.
    • Deploy v1.3.0 operator and v5.3.0 cluster, use TiFlash, then upgrade operator and cluster to v5.4.0 cluster, check the result of using TiFlash.
    • Deploy v1.3.0 operator and v5.4.0 cluster, use TiFlash, then upgrade operator, check the result of using TiFlash.
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Fix the issue about creating TiFlash replicas for tables

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

@KanShiori you're already a collaborator in bot's repo.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ebeae91

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #4436 (ebeae91) into release-1.3 (2cba41f) will increase coverage by 9.80%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-1.3    #4436      +/-   ##
===============================================
+ Coverage        62.37%   72.18%   +9.80%     
===============================================
  Files              184      188       +4     
  Lines            19774    22177    +2403     
===============================================
+ Hits             12335    16008    +3673     
+ Misses            6295     5037    -1258     
+ Partials          1144     1132      -12     
Flag Coverage Δ
e2e 60.08% <0.00%> (?)
unittest 62.38% <100.00%> (+<0.01%) ⬆️

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

1 similar comment
@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

@ti-chi-bot ti-chi-bot merged commit 8342648 into pingcap:release-1.3 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants