-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tiflash config after v5.4.0 (#4430) #4436
Fix tiflash config after v5.4.0 (#4430) #4436
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@KanShiori you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ebeae91
|
Codecov Report
@@ Coverage Diff @@
## release-1.3 #4436 +/- ##
===============================================
+ Coverage 62.37% 72.18% +9.80%
===============================================
Files 184 188 +4
Lines 19774 22177 +2403
===============================================
+ Hits 12335 16008 +3673
+ Misses 6295 5037 -1258
+ Partials 1144 1132 -12
|
/test pull-e2e-kind |
1 similar comment
/test pull-e2e-kind |
cherry-pick #4430 to release-1.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb-operator repo: git pr https://github.com/pingcap/tidb-operator/pull/4436
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Close #4434
Close #4435
What is changed and how does it work?
Code changes
Tests
Unit test
E2E test
Manual test
No code
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.