TiFlash lose metadata after upgrade to v5.4.0

[KanShiori]

Bug Report

What version of TiDB Operator are you using?

v1.3.0 or v1.3.0-beta.1

What did you do?

If deploying v1.3.0 or v1.3.0-beta.1 operator, TiFlash will lose metadata after upgrading TiFlash to v5.4.0.

What did you expect to see?

What did you see instead?

[KanShiori]

For v1.3.0 or v1.3.0-beta.1 operator, operator set the default config storage.raft.dir of TiFlash to a string "/data0/kvstore".

tidb-operator/pkg/manager/member/tiflash_util.go

Lines 150 to 153 in 17b1e59

	// check "raft.kvstore_path" to be compatible with old version
	if common.Get("raft.kvstore_path") == nil {
	common.SetIfNil("storage.raft.dir", "/data0/kvstore")
	}

This config should be an array so that TiFlash will use the default value "/data0/db/kvstore". So after upgrading to v5.4.0, the value of storage.raft.dir will change, resulting in lost data.

[KanShiori]

Fixed by #4430, and released in v1.3.1