Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tiflash config after v5.4.0 #4430

Merged
merged 6 commits into from
Feb 22, 2022
Merged

Fix tiflash config after v5.4.0 #4430

merged 6 commits into from
Feb 22, 2022

Conversation

KanShiori
Copy link
Collaborator

@KanShiori KanShiori commented Feb 22, 2022 •
edited
Loading

What problem does this PR solve?

Close #4434
Close #4435

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test

  • E2E test

  • Manual test

    • Deploy operator and v5.4.0 cluster, check the result of using TiFlash.
    • Deploy v1.3.0 operator and v5.3.0 cluster, use TiFlash, then upgrade operator and cluster to v5.4.0 cluster, check the result of using TiFlash.
    • Deploy v1.3.0 operator and v5.4.0 cluster, use TiFlash, then upgrade operator, check the result of using TiFlash.

  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Fix the issue about creating TiFlash replicas for tables

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

DanielZhangQD
DanielZhangQD approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022 •
edited
Loading

Codecov Report

Merging #4430 (41984a6) into master (2493cf0) will increase coverage by 9.66%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4430      +/-   ##
==========================================
+ Coverage   62.36%   72.03%   +9.66%     
==========================================
  Files         184      188       +4     
  Lines       19774    22177    +2403     
==========================================
+ Hits        12333    15976    +3643     
+ Misses       6296     5072    -1224     
+ Partials     1145     1129      -16
Flag Coverage Δ
e2e 59.94% <0.00%> (?)
unittest 62.38% <100.00%> (+0.01%) ⬆️

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-br

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 41984a6

@KanShiori KanShiori mentioned this pull request Feb 22, 2022
Closed
7 tasks
@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-br

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

1 similar comment
@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-br

1 similar comment
@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-br

This was referenced Feb 22, 2022
Closed
Closed
@ti-chi-bot ti-chi-bot merged commit 1eb8baa into pingcap:master Feb 22, 2022
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Feb 22, 2022
@KanShiori @ti-srebot
cherry pick pingcap#4430 to release-1.3
ebeae91 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Feb 22, 2022
Merged
13 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.3 in PR #4436

ti-chi-bot pushed a commit that referenced this pull request Feb 23, 2022
@ti-srebot
Fix tiflash config after v5.4.0 (#4430) (#4436)
8342648
@DanielZhangQD
Copy link
Contributor

Verified cases:

  • Deploy TiDB Operator v1.3.0 + TiDB/TiFlash v5.3.0
    • Check TiDB cluster is ready
    • Prepare 3 tables with sysbench
    • Enable TiFlash replica for table 1, check that replica is ready in TiFlash and data can be queried from TiFlash
    • Upgrade to the TiDB Operator with this fix, no rolling update occurs, data in table 1 can be queried from TiFlash
    • Enable TiFlash replica for table 2, check that replica is ready in TiFlash and data can be queried from TiFlash
    • Upgrade TiDB/TiFlash to v5.4.0, TiDB cluster is ready, enable TiFlash replica for table 3, check that replica is ready in TiFlash and data in table 1,2,3 can be queried from TiFlash.
  • Deploy TiDB Operator v1.3.0 + TiDB/TiFlash v5.4.0
    • Check TiDB cluster is ready
    • Prepare 3 tables with sysbench
    • Enable TiFlash replica for table 1, check that replica is ready in TiFlash and data can be queried from TiFlash
    • Upgrade to the TiDB Operator with this fix (follow the procedure in https://github.com/pingcap/docs-tidb-operator/pull/1694/files), data in table 1 can be queried from TiFlash
    • Enable TiFlash replica for table 2, check that replica is ready in TiFlash and data can be queried from TiFlash
  • Deploy TiDB Operator v1.2.7 + TiDB/TiFlash v5.3.0
    • Check TiDB cluster is ready
    • Prepare 3 tables with sysbench
    • Enable TiFlash replica for table 1, check that replica is ready in TiFlash and data can be queried from TiFlash
    • Upgrade to the TiDB Operator with this fix, no rolling update occurs, data in table 1 can be queried from TiFlash
    • Enable TiFlash replica for table 2, check that replica is ready in TiFlash and data can be queried from TiFlash
    • Upgrade TiDB/TiFlash to v5.4.0, TiDB cluster is ready, enable TiFlash replica for table 3, check that replica is ready in TiFlash and data in table 1,2,3 can be queried from TiFlash.
  • Deploy TiDB Operator v1.2.7 + TiDB/TiFlash v5.4.0
    • Check TiDB cluster is ready
    • Prepare 3 tables with sysbench
    • Enable TiFlash replica for table 1, check that replica is ready in TiFlash and data can be queried from TiFlash
    • Upgrade to the TiDB Operator with this fix, rolling update occurs, data in table 1 can be queried from TiFlash
    • Enable TiFlash replica for table 2, check that replica is ready in TiFlash and data can be queried from TiFlash

@DanielZhangQD DanielZhangQD mentioned this pull request Feb 23, 2022
Closed
@KanShiori KanShiori deleted the fix_tiflash_config branch March 22, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@july2993 july2993 Awaiting requested review from july2993

Assignees
No one assigned
Labels
needs-cherry-pick-1.3 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use v5.4.0 TiFlash with Operator v1.3.0/v1.3.0-beta.1 TiFlash lose metadata after upgrade to v5.4.0
6 participants
@KanShiori @ti-chi-bot @codecov-commenter @DanielZhangQD @ti-srebot @csuzhangxc