Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not recommend setting tiflash logical split since 6.2 #9895

Merged
merged 5 commits into from
Aug 11, 2022

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Aug 9, 2022

Signed-off-by: JaySon-Huang [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

According to pingcap/tiflash#5576, if user deploys tiflash with explicit setting profiles.default.dt_enable_logical_split = 1.
After several logical split, PageStorage V3 will throw an exception for the third time logical split and make TiFlash crash.

Here we declare the config item to be deprecated

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: JaySon-Huang <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from shichun-0415 August 9, 2022 13:23
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2022
@JaySon-Huang
Copy link
Contributor Author

/cc @flowbehappy

@ti-chi-bot ti-chi-bot requested a review from flowbehappy August 9, 2022 13:24
Comment on lines 180 to 181
## Note that logical split has compatibility issues with other features since v6.2.0 and
## it is not recommended to set the value to true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Note that logical split has compatibility issues with other features since v6.2.0 and
## it is not recommended to set the value to true.
## Note that logical split has known issue on v6.2.0 and later versions,
## it is strongly not recommended to set the value to true.

@JaySon-Huang JaySon-Huang changed the title deprecated logical split Not recommend setting tiflash logical split since 6.2 Aug 10, 2022
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang JaySon-Huang force-pushed the logical_split_settings branch from 1a8be2d to c6f5ae6 Compare August 10, 2022 04:13
@JaySon-Huang
Copy link
Contributor Author

PTAL again @shichun-0415 @flowbehappy

Signed-off-by: JaySon-Huang <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2022
@shichun-0415
Copy link
Contributor

/verify

@shichun-0415 shichun-0415 requested a review from ran-huang August 10, 2022 14:19
Signed-off-by: JaySon-Huang <[email protected]>
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.2 This PR/issue applies to TiDB v6.2. and removed missing-translation-status This PR does not have translation status info. labels Aug 11, 2022
@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2
/merge

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 11, 2022
@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 25f5292

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2022
@shichun-0415 shichun-0415 merged commit d3b09d8 into pingcap:master Aug 11, 2022
@JaySon-Huang JaySon-Huang deleted the logical_split_settings branch August 11, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants