Not recommend setting tiflash logical split since 6.2 #10840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
missing-translation-status
Signed-off-by: JaySon-Huang <[email protected]>
JaySon-Huang
force-pushed
the
logical_split_settings
branch
from
6614511 to
5a91553
Compare
Signed-off-by: JaySon-Huang <[email protected]>
|
/cc @flowbehappy |
13 tasks
Lloyd-Pottiger
approved these changes
Aug 9, 2022
flowbehappy
approved these changes
Aug 9, 2022
flowbehappy
reviewed
Aug 9, 2022
JaySon-Huang
changed the title
Signed-off-by: JaySon-Huang <[email protected]>
|
Comment addressed. PTAL again @shichun-0415 @flowbehappy |
Co-authored-by: shichun-0415 <[email protected]>
shichun-0415
added
translation/doing
Co-authored-by: shichun-0415 <[email protected]>
ti-chi-bot
added
status/LGT2
|
/verify |
Signed-off-by: JaySon-Huang <[email protected]>
|
/verify |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 710f911
|
ti-chi-bot
added
the
status/can-merge
shichun-0415
added
translation/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang [email protected]
First-time contributors' checklist
What is changed, added or deleted? (Required)
According to pingcap/tiflash#5576, if user deploys tiflash with explicit setting
profiles.default.dt_enable_logical_split = 1.After several logical split, PageStorage V3 will throw an exception for the third time logical split and make TiFlash crash.
Here we declare the config item to be deprecated
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?