Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not recommend setting tiflash logical split since 6.2 #9895

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Not recommend setting tiflash logical split since 6.2 #9895

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5eaafec
deprecated logical split
JaySon-Huang Aug 9, 2022
c6f5ae6
address comment
JaySon-Huang Aug 10, 2022
327fe88
address comment
JaySon-Huang Aug 10, 2022
fa4be60
Apply suggestions from code review
JaySon-Huang Aug 10, 2022
25f5292
sync
JaySon-Huang Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tiflash/tiflash-configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,12 @@ delta_index_cache_size = 0
[profiles]

[profiles.default]
## The default value is false. This parameter determines whether the segment
## [Deprecated] The default value is false. This parameter determines whether the segment
## of DeltaTree Storage Engine uses logical split.
## Using the logical split can reduce the write amplification.
## However, these are at the cost of disk space waste.
## Modifying the default value is not recommended.
## Note that logical split has compatibility issues with other features since v6.2.0 and
## it is not recommended to set the value to true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Note that logical split has compatibility issues with other features since v6.2.0 and
## it is not recommended to set the value to true.
## Note that logical split has known issue on v6.2.0 and later versions,
## it is strongly not recommended to set the value to true.

# dt_enable_logical_split = false

## The memory usage limit for the generated intermediate data when a single
Expand All @@ -197,9 +198,9 @@ delta_index_cache_size = 0
manual_compact_pool_size = 1
## New in v5.4.0. This item enables or disables the elastic thread pool feature, which significantly improves CPU utilization in high concurrency scenarios of TiFlash. The default value is true.
enable_elastic_threadpool = true
# Compression algorithm of the TiFlash storage engine. The value can be LZ4, zstd, or LZ4HC, and is case-insensitive. By default, LZ4 is used.
## Compression algorithm of the TiFlash storage engine. The value can be LZ4, zstd, or LZ4HC, and is case-insensitive. By default, LZ4 is used.
dt_compression_method = "LZ4"
# Compression level of the TiFlash storage engine. The default value is 1. It is recommended that you set this value to 1 if dt_compression_method is LZ4, -1 (smaller compression rate, but better read performance) or 1 if dt_compression_method is zstd, and 9 if dt_compression_method is LZ4HC.
## Compression level of the TiFlash storage engine. The default value is 1. It is recommended that you set this value to 1 if dt_compression_method is LZ4, -1 (smaller compression rate, but better read performance) or 1 if dt_compression_method is zstd, and 9 if dt_compression_method is LZ4HC.
dt_compression_level = 1

## New in v6.2.0. Use the thread pool to handle read requests from the storage engine. The default value is false.
Expand Down