Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctl: add a note for all ctl docs #6096

Merged
merged 1 commit into from
Apr 21, 2021
Merged

ctl: add a note for all ctl docs #6096

merged 1 commit into from
Apr 21, 2021

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Apr 21, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 21, 2021 03:09
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 21, 2021
@yikeke yikeke added needs-cherry-pick-3.1 translation/doing This PR’s assignee is translating this PR. labels Apr 21, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 21, 2021
@yikeke yikeke requested a review from King-Dylan April 21, 2021 03:10
@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2021
King-Dylan
King-Dylan approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@King-Dylan King-Dylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

@King-Dylan: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yikeke
Copy link
Contributor Author

yikeke commented Apr 21, 2021

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 21, 2021
@yikeke
Copy link
Contributor Author

yikeke commented Apr 21, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 659c4d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2021
@ti-chi-bot ti-chi-bot merged commit ab487f7 into pingcap:master Apr 21, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 21, 2021
@yikeke @ti-srebot
cherry pick pingcap#6096 to release-2.1
2c1753b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #6097

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 21, 2021
@yikeke @ti-srebot
cherry pick pingcap#6096 to release-3.0
0809190 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #6098

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 21, 2021
@yikeke @ti-srebot
cherry pick pingcap#6096 to release-3.1
0a10de4 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #6099

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 21, 2021
@yikeke @ti-srebot
cherry pick pingcap#6096 to release-4.0
f6d912e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #6100

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 21, 2021
@yikeke @ti-srebot
cherry pick pingcap#6096 to release-5.0
66404e8 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6101

@yikeke yikeke mentioned this pull request Apr 21, 2021
Merged
11 tasks
ti-chi-bot pushed a commit that referenced this pull request Apr 21, 2021
@ti-srebot
ctl: add a note for all ctl docs (#6096) (#6101)
09e171f
ti-chi-bot pushed a commit that referenced this pull request Apr 21, 2021
@ti-srebot
ctl: add a note for all ctl docs (#6096) (#6100)
8a6283d
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
ctl: add a note for all ctl docs (#6096) (#6099)
10d1fbe
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
ctl: add a note for all ctl docs (#6096) (#6098)
d875f0f
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
ctl: add a note for all ctl docs (#6096) (#6097)
4fd384e
@Joyinqin Joyinqin mentioned this pull request Apr 22, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 22, 2021
This was referenced Apr 26, 2021
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@King-Dylan King-Dylan King-Dylan approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@Joyinqin Joyinqin

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yikeke @TomShawn @ti-chi-bot @ti-srebot @Joyinqin @King-Dylan