Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctl: add a note for all ctl docs #5435

Merged
merged 3 commits into from
Apr 26, 2021
Merged

ctl: add a note for all ctl docs #5435

merged 3 commits into from
Apr 26, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Apr 22, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 22, 2021 06:50
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2021
@TomShawn
Copy link
Contributor

/cc @yikeke
/uncc @TomShawn

@ti-chi-bot ti-chi-bot requested review from yikeke and removed request for TomShawn April 22, 2021 06:50
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/label needs-cherry-pick-3.0
/label needs-cherry-pick-3.1
/label needs-cherry-pick-2.1
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 22, 2021
@Joyinqin
Copy link
Contributor Author

/cc @King-Dylan

@ti-chi-bot ti-chi-bot requested a review from King-Dylan April 22, 2021 06:53
@yikeke yikeke requested review from qiancai and removed request for yikeke April 25, 2021 09:22
@qiancai
Copy link
Collaborator

qiancai commented Apr 25, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@qiancai: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/label require-LGT1
/lgtm

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 26, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e79e6d1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@ti-chi-bot ti-chi-bot merged commit 70a6d90 into pingcap:master Apr 26, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5435 to release-2.1
d6f429e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #5508

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5435 to release-3.0
76ba0f5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #5509

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5435 to release-3.1
bdd4f58 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #5510

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5435 to release-4.0
d2f6501 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5511

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5435 to release-5.0
a958fd5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5512

ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
ctl: add a note for all ctl docs (#5435) (#5512)
6fbcbf4
ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
ctl: add a note for all ctl docs (#5435) (#5511)
aa12c43
@Joyinqin Joyinqin deleted the add-note-for-ctl-tools branch April 27, 2021 03:04
@Joyinqin
Copy link
Contributor Author

All cp changes are completed. PTAL, thx~ @TomShawn

ti-chi-bot pushed a commit that referenced this pull request Apr 27, 2021
@ti-srebot
ctl: add a note for all ctl docs (#5435) (#5510)
7b468f1
ti-chi-bot pushed a commit that referenced this pull request Apr 27, 2021
@ti-srebot
ctl: add a note for all ctl docs (#5435) (#5509)
a9fcc29
ti-chi-bot pushed a commit that referenced this pull request Apr 27, 2021
@ti-srebot
ctl: add a note for all ctl docs (#5435) (#5508)
5374abb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@King-Dylan King-Dylan Awaiting requested review from King-Dylan

@qiancai qiancai Awaiting requested review from qiancai

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @TomShawn @qiancai @ti-chi-bot @ti-srebot