Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master/5.0: bump version and links to v5.0.0 #5773

Merged
merged 12 commits into from
Apr 27, 2021

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Mar 18, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update the code examples and links after 5.0 GA, so we guide users to try a newer version of TiDB.

请帮忙确认里头的版本号和链接在 5.0 GA 发版后是否正确 @King-Dylan

⚠️注意:此 PR 会在 5.0 GA 发版后合并

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2021
@yikeke yikeke added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-5.0 v5.0 This PR/issue applies to TiDB v5.0 labels Mar 18, 2021
@yikeke
Copy link
Contributor Author

yikeke commented Mar 18, 2021

/cc @qiancai @TomShawn

@ti-chi-bot ti-chi-bot requested review from qiancai and TomShawn March 18, 2021 09:55
@yikeke
Copy link
Contributor Author

yikeke commented Mar 18, 2021

/cc @King-Dylan

@ti-chi-bot ti-chi-bot requested a review from King-Dylan March 18, 2021 09:56
CONTRIBUTING.md Outdated Show resolved Hide resolved
download-ecosystem-tools.md Show resolved Hide resolved
maintain-tidb-using-tiup.md Outdated Show resolved Hide resolved
@@ -49,7 +49,7 @@ mysql -u root -h 10.0.1.4 -P 4000
```sql
Welcome to the MySQL monitor. Commands end with ; or \g.
Your MySQL connection id is 3
Server version: 5.7.25-TiDB-v4.0.0 TiDB Server (Apache License 2.0) Community Edition, MySQL 5.7 compatible
Server version: 5.7.25-TiDB-v5.0.0 TiDB Server (Apache License 2.0) Community Edition, MySQL 5.7 compatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这个结果也需要验证

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等 tech review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有问题

yikeke and others added 2 commits March 18, 2021 19:11
pd-control.md Outdated Show resolved Hide resolved
pd-recover.md Outdated Show resolved Hide resolved
@yikeke yikeke added translation/doing This PR’s assignee is translating this PR. and removed v5.0 This PR/issue applies to TiDB v5.0 labels Mar 24, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 24, 2021
@yikeke yikeke added the v5.0 This PR/issue applies to TiDB v5.0 label Mar 31, 2021
README.md Outdated Show resolved Hide resolved
@yikeke yikeke changed the title master/5.0: update low-version code examples and links master/5.0: update code examples and links to v5.0.0 Apr 7, 2021
@yikeke yikeke requested a review from IANTHEREAL April 7, 2021 06:39
@yikeke yikeke requested a review from nolouch April 7, 2021 06:46
@yikeke
Copy link
Contributor Author

yikeke commented Apr 7, 2021

Please help review the tool part @IANTHEREAL
Please help review the PD part @nolouch
Please help review the deploy/maintain part @King-Dylan

@yikeke
Copy link
Contributor Author

yikeke commented Apr 7, 2021

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@ti-chi-bot ti-chi-bot added area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. labels Apr 20, 2021
@yikeke
Copy link
Contributor Author

yikeke commented Apr 20, 2021

@IANTHEREAL: /lgtm is only allowed for the reviewers in list.

After adding the sig/migrate label, you should be able to review the PR now. @IANTHEREAL

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2021
pd-recover.md Outdated Show resolved Hide resolved
@yikeke yikeke changed the title master/5.0: update code examples and links to v5.0.0 master/5.0: bump version and links to v5.0.0 Apr 21, 2021
@ti-chi-bot
Copy link
Member

@King-Dylan: /lgtm is only allowed for the reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@@ -17,7 +17,7 @@ aliases: ['/docs-cn/dev/download-ecosystem-tools/','/docs-cn/dev/reference/tools

> **注意:**
>
> 下载链接中的 `{version}` 为 TiDB 的版本号。例如,`v4.0.8` 版本的下载链接为 `https://download.pingcap.org/tidb-v4.0.8-linux-amd64.tar.gz`。
> 下载链接中的 `{version}` 为 TiDB 的版本号。例如,`v5.0.0` 版本的下载链接为 `https://download.pingcap.org/tidb-v5.0.0-linux-amd64.tar.gz`。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

马上要发 5.0.1 了,是不是还得更新?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是举例,我们改大版本就好,不用每发一个 patch 版本都更新

@yikeke
Copy link
Contributor Author

yikeke commented Apr 27, 2021

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 27, 2021
@yikeke
Copy link
Contributor Author

yikeke commented Apr 27, 2021

/MERGE

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 29de347

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2021
@ti-chi-bot ti-chi-bot merged commit b93e3ad into pingcap:master Apr 27, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 27, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6179

@CharLotteiu
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants