This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
.*: fix bug that after execute pause-task the task may still running #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangXiangUSTC
added
status/PTAL
csuzhangxc
reviewed
Apr 29, 2020
|
/run-all-tests |
csuzhangxc
reviewed
Apr 29, 2020
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
================================================
- Coverage 57.8327% 57.7236% -0.1092%
================================================
Files 202 203 +1
Lines 20561 20515 -46
================================================
- Hits 11891 11842 -49
- Misses 7524 7526 +2
- Partials 1146 1147 +1 |
lichunzhu
reviewed
Apr 29, 2020
dm/worker/subtask.go
Outdated
| @@ -462,6 +472,7 @@ func (st *SubTask) Resume() error { | |||
| st.setStage(pb.Stage_Paused) | |||
| return err | |||
| } else if ctx.Err() != nil { | |||
| st.setStage(pb.Stage_Paused) | |||
There was a problem hiding this comment.
I think this should not be set to pb.Stage_Paused, see #589 (comment)
There was a problem hiding this comment.
ok, I remove this and add a comment e34ec49
|
/run-all-tests |
|
/run-all-tests |
lichunzhu
reviewed
Apr 30, 2020
tests/sharding/run.sh
Outdated
| run_dm_ctl_with_retry $WORK_DIR "127.0.0.1:$MASTER_PORT" \ | ||
| "resume-task test"\ | ||
| "\"result\": true" 3 | ||
| # resume twice |
There was a problem hiding this comment.
Should we add a test to test stop-task twice?
There was a problem hiding this comment.
add in ecd45e6
csuzhangxc
added
status/LGT1
|
/run-all-tests |
|
/run-all-tests |
lichunzhu
added
status/LGT2
This was referenced Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix issue #637 and #629
when executing pause task the task is not real paused, and then execute resume task, maybe the old unit is still process, and then will cause some problem.
What is changed and how it works?
pausingandresuming:pausing, and update stage topausedat the last.resuming, and update stage torunningat the last.fetchResultshould wait for the unit's process result.Check List
Tests