Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: data race for collectMetrics #637

Closed
csuzhangxc opened this issue Apr 27, 2020 · 1 comment
Closed

syncer: data race for collectMetrics #637

csuzhangxc opened this issue Apr 27, 2020 · 1 comment
Assignees
@WangXiangUSTC
Labels
severity/minor type/bug This issue is a bug report
Milestone
v2.0.0 beta.1

Comments

@csuzhangxc
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

    run CI

  2. What did you expect to see?

    passed as normal.

  3. What did you see instead?

    data race detected, see https://internal.pingcap.net/idc-jenkins/blue/rest/organizations/jenkins/pipelines/dm_ghpr_test/runs/4757/nodes/73/log/?start=0.

    this should be caused by resume-task may resume a not real paused (still running) task #629.

  4. Versions of the cluster

    • DM version (run dmctl -V or dm-worker -V or dm-master -V):

      https://github.com/pingcap/dm/pull/615
@csuzhangxc csuzhangxc added the type/bug This issue is a bug report label Apr 27, 2020
@WangXiangUSTC WangXiangUSTC mentioned this issue Apr 29, 2020
Merged
@csuzhangxc csuzhangxc added this to the v2.0.0 beta.1 milestone Apr 30, 2020
@WangXiangUSTC
Copy link
Contributor

fix in #644

@WangXiangUSTC WangXiangUSTC self-assigned this Apr 30, 2020
@WangXiangUSTC WangXiangUSTC mentioned this issue Jun 16, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@WangXiangUSTC WangXiangUSTC

Labels
severity/minor type/bug This issue is a bug report
Projects
None yet
Milestone
v2.0.0 beta.1
Development

No branches or pull requests
3 participants
@csuzhangxc @WangXiangUSTC @sre-bot