This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
worker/: fix worker stuck in unitTransWaitCondition #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
priority/normal
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
================================================
+ Coverage 57.8518% 58.1985% +0.3466%
================================================
Files 201 201
Lines 20371 20461 +90
================================================
+ Hits 11785 11908 +123
+ Misses 7455 7417 -38
- Partials 1131 1136 +5 |
csuzhangxc
reviewed
Apr 10, 2020
csuzhangxc
reviewed
Apr 16, 2020
| if err != nil { | ||
| st.l.Error("wait condition", log.ShortError(err)) | ||
| st.fail(err) | ||
| return | ||
| } else if ctx.Err() != nil { | ||
| return |
There was a problem hiding this comment.
Will the stage keep as Stage_Running?
There was a problem hiding this comment.
ctx.Err() != nil means this context is canceled in other go routine, that go routine will change the stage.
There was a problem hiding this comment.
So, how about checking the stage in the unit test cases?
|
/run-all-tests |
WangXiangUSTC
added
status/LGT2
|
cherry pick to release-1.0 failed |
|
@lichunzhu please do not forget to cherry-pick it manually. |
@csuzhangxc OK |
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 21, 2020
csuzhangxc
pushed a commit
that referenced
this pull request
Apr 23, 2020
csuzhangxc
added
already-cherry-pick-1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#576
When subtask is started, it will use
unitTransWaitConditionto wait for relay log to catch up. But if this task is paused or stopped, we should quit as fast as we can instead of keeping waiting.What is changed and how it works?
st.currCtxto control wait ofunitTransWaitCondition.st.ctxand son contextst.currCtxto make sure task can be shut down.Check List
Tests
Related changes