twigcs exclude subfolders #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
reviewed
Oct 10, 2019
veewee
reviewed
Oct 10, 2019
veewee
reviewed
Oct 10, 2019
|
@oallain Thanks for the PR! |
veewee
reviewed
Oct 10, 2019
oallain
force-pushed
the
feature/twigcs-exclude
branch
from
d906c65 to
0a5dd6f
Compare
Landerstraeten
approved these changes
Nov 29, 2019
|
Will a beta version friendsoftwig/twigcs#82 (comment) be okay or do need to use a stable version? Since I have used patch until now and it works fine. |
oallain
force-pushed
the
feature/twigcs-exclude
branch
from
0a5dd6f to
99ce3e1
Compare
|
@truls1502 thanks for feedback :) I rebase this PR and update it with new Task tests with PHPUnit.
Anyone know why? |
veewee
reviewed
Mar 19, 2020
|
Thanks for rebasing! Looks like we can merge it in and still keep BC to the older version of the tool, so good to go IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exclude option on TwigCs after add it in friendsoftwig/twigcs#81
I think we have to wait for the next Tag on friendsoftwig/twigcs before we merge this PR, because the feature is only on Master branch currently 😉 (See friendsoftwig/twigcs#82)