Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #5

Closed
veewee opened this issue Mar 23, 2015 · 2 comments
Closed

Windows support #5

veewee opened this issue Mar 23, 2015 · 2 comments

Comments

@veewee
Copy link
Contributor

veewee commented Mar 23, 2015

GrumPHP is not working on Windows CLI. This is because composer installs bat files for every bin file.
Some actions need to be taken:

  • Remove the 'php' prefix in all process builders
  • Make sure every processbuilder uses the external CommandLocator
  • Check the OS in the CommandLocator and add .bat to the command if it is windows
  • Possibly there is also a path problem. Windows uses the backslash as directory separator, and unix uses the frontslash.

Extra installation checks:

  • We need to check if there is a git executable available. This could be handy in both windows as unix. If there is no git executable, an error message needs to be displayed and GrumPHP won't be hooked. Maybe we could take a look at the composer files to see how they resolve the git exectuable in windows.
  • We assume the php executable is available, otherwise composer won't be able to install it's packages.
@veewee
Copy link
Contributor Author

veewee commented Apr 4, 2015

The GitElephant package does not support windows by default and has some issues:

  • It uses the process builder incorrectly
  • It can only find git executable on windows
  • The status command does not recognice deleted and moved files

To make GrumPHP windows compatible, it might be better to use another git package.
At first sight, we might use: https://github.com/gitonomy/gitlib
It works with the process builder and has windows support.

@veewee veewee mentioned this issue Apr 21, 2015
@veewee
Copy link
Contributor Author

veewee commented Apr 21, 2015

Fixed in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant