Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwigCs - allocine/twigcs is abandoned. Changed to friendsoftwig/twigcs #657

Merged
merged 2 commits into from
Jul 28, 2019
Merged

TwigCs - allocine/twigcs is abandoned. Changed to friendsoftwig/twigcs #657

merged 2 commits into from
Jul 28, 2019

Conversation

truls1502
Copy link
Contributor

@truls1502 truls1502 commented Jul 27, 2019

Q A
Branch master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no

Updated TwigCs from allocine/twigcs to friendsoftwig/twigcs when allocine/twigcs is abandoned and no longer maintained.

New Task Checklist:

  • Is the README.md file updated?
  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpspec tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

@veewee veewee added this to the 0.16.0 milestone Jul 28, 2019
@veewee veewee merged commit 4dd9aa2 into phpro:master Jul 28, 2019
@veewee
Copy link
Contributor

veewee commented Jul 28, 2019

Thanks for the PR!

@truls1502 truls1502 deleted the fix/twigcs-from-allocine-to-friendsoftwig branch July 28, 2019 22:13
@drupol
Copy link
Contributor

drupol commented Sep 18, 2019

We should add a "exclude" folders option so it doesn't check in the vendor directory, but this must be done in https://github.com/friendsoftwig/twigcs directly I think.

@oallain
Copy link
Contributor

oallain commented Oct 7, 2019

We should add a "exclude" folders option so it doesn't check in the vendor directory, but this must be done in https://github.com/friendsoftwig/twigcs directly I think.

Hello, @drupol
I had a new PR in TwigCs for that 😉

Hoping it will help you.

@drupol
Copy link
Contributor

drupol commented Oct 7, 2019

Nice ! Link ?

@truls1502
Copy link
Contributor Author

@oallain - is this PR friendsoftwig/twigcs#81?

@oallain
Copy link
Contributor

oallain commented Oct 8, 2019

Yes, it's that.

I'll create a new PR here for integrate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants