Improved composer plugin #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
force-pushed
the
composer-plugin-rewrite
branch
from
4f98ebf to
cbdc72b
Compare
veewee
force-pushed
the
composer-plugin-rewrite
branch
from
7f34896 to
bb522b0
Compare
veewee
force-pushed
the
composer-plugin-rewrite
branch
from
3b75bf2 to
ab00e3d
Compare
| @@ -0,0 +1 @@ | |||
| 3 | |||
There was a problem hiding this comment.
I think you need to delete this file
| // Windows requires double double quotes | ||
| // https://bugs.php.net/bug.php?id=49139 | ||
| $windowsIsInsane = function (string $command) { | ||
| return $this->runsOnWindows() ? '"'.$command.'"' : $command; |
oallain
reviewed
Nov 29, 2019
| @@ -19,7 +19,7 @@ public static function integrate(Event $event): void | |||
| $filesystem = new Filesystem(); | |||
|
|
|||
| $composerBinDir = $event->getComposer()->getConfig()->get('bin-dir'); | |||
| $executable = getcwd().'/bin/grumphp'; | |||
| $executable = __DIR__.'/../../bin/grumphp'; | |||
There was a problem hiding this comment.
Suggested change
| $executable = __DIR__.'/../../bin/grumphp'; | |
| $executable = dirname(__DIR__, 2) . '/bin/grumphp'; |
Landerstraeten
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress. The goals of this rewrite are:
Todos:
Testing:
composer.json
{ "require": { "phpro/grumphp": "dev-composer-plugin-rewrite" }, "repositories": [ { "type": "git", "url": "[email protected]:veewee/grumphp.git" } ] }