is_executable is buggy on windows

phpro · Oct 4, 2019 · 7f34896 · 7f34896
1 parent 2156bbd
commit 7f34896
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/appveyor.yml b/appveyor.yml
@@ -71,5 +71,4 @@ install:
 
 test_script:
   - ps: cd $Env:project_directory
-  # - php ./bin/grumphp run
-  - ./vendor/bin/phpunit --testsuite=E2E --filter='it_has_all_config_files_in_root_git_dir'
+  - php ./bin/grumphp run
diff --git a/src/Composer/GrumPHPPlugin.php b/src/Composer/GrumPHPPlugin.php
@@ -253,7 +253,7 @@ private function detectGrumphpExecutable(): ?string
             $suffixes,
             function (?string $carry, string $suffix) use ($binDir): ?string {
                 $possiblePath = $binDir.DIRECTORY_SEPARATOR.self::APP_NAME.$suffix;
-                if ($carry || !file_exists($possiblePath) || !is_executable($possiblePath)) {
+                if ($carry || !file_exists($possiblePath)) {
                     return $carry;
                 }
 

diff --git a/test/E2E/AbstractE2ETestCase.php b/test/E2E/AbstractE2ETestCase.php
@@ -290,15 +290,12 @@ protected function installComposer(string $path, array $arguments = [])
                     'install',
                     '--optimize-autoloader',
                     '--no-interaction',
-                    '-vvv',
                 ],
                 $arguments),
             $path
         );
 
         $this->runCommand('install composer', $process);
-
-        echo $process->getOutput() . PHP_EOL . $process->getErrorOutput();
     }
 
     protected function commitAll(string $gitPath = null)