Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensiolabs/security-checker is abandoned and replaced by fabpot/local-php-security-checker #865

Closed
Orteko opened this issue Jan 19, 2021 · 6 comments · Fixed by #870
Closed

Comments

@Orteko
Copy link

Orteko commented Jan 19, 2021

Q A
Version 0.18.1
Bug? no
New feature? no
Question? no
Documentation? no
Related tickets N/A

sensiolabs/security-checker has been marked as abandoned and the free api at security.symfony.com will be stopped at the end of January 2021.

It has apparently been replaced by fabpot/local-php-security-checker so the securitychecker task may need to be updated to move to use this instead.

@ctrl-f5
Copy link

ctrl-f5 commented Jan 25, 2021

As we dont want to mess around with binaries and want to keep everything inside our composer, we are looking into switching to https://github.com/Roave/SecurityAdvisories

It uses the same source repo to check for vulnerabilities as fabpot/local-php-security-checker.

One caveat is that it only runs checks during require and update, but it could be triggered by grumphp with:

composer update --dry-run roave/security-advisories

@veewee
Copy link
Contributor

veewee commented Jan 25, 2021

@ctrl-f5 : Maybe we could make 2 tasks instead? The task takes some configurable options, which won't be possible with the package from roave.

So we could change the existing task and extend it with an option to select the executable: symfony or local-php-security-checker.
Besides that, we could add the one from roave as a separate task.

@ctrl-f5
Copy link

ctrl-f5 commented Jan 25, 2021

yup, having both options will be best. I will try and find the time to create a task for the roave package.

@paras-malhotra
Copy link
Contributor

paras-malhotra commented Jan 28, 2021

Guys, you can consider the Enlightn Security Checker. No binaries needed, can be pulled in with Composer, no licensing issues (MIT license) and has in-built HTTP caching.

@JeppeKnockaert
Copy link
Contributor

As @paras-malhotra stated, local-php-security-checker doesn't seem a good alternative due to licensing.

If there's still interest in using local-php-security-checker, or if their license were to change, you can always reopen #871 (or use it as a starting point).

@Orteko
Copy link
Author

Orteko commented Feb 4, 2021

Awesome - thanks guys!

ArjenMiedema pushed a commit to ArjenMiedema/testing-suite that referenced this issue Feb 18, 2021
To replace the Symfony Security Checker, the Enlightn Security
Checker has been installed, which does the same checks and is
already enabled in the GrumPHP configuration.

See: phpro/grumphp#865
ArjenMiedema pushed a commit to ArjenMiedema/testing-suite that referenced this issue Feb 18, 2021
To replace the Symfony Security Checker, the Enlightn Security
Checker has been installed, which does the same checks and is
already enabled in the GrumPHP configuration.

See: phpro/grumphp#865
ArjenMiedema pushed a commit to ArjenMiedema/testing-suite that referenced this issue Feb 18, 2021
To replace the Symfony Security Checker, the Enlightn Security
Checker has been installed, which does the same checks and is
already enabled in the GrumPHP configuration.

See: phpro/grumphp#865
ksangers pushed a commit to mediact/testing-suite that referenced this issue Feb 18, 2021
To replace the Symfony Security Checker, the Enlightn Security
Checker has been installed, which does the same checks and is
already enabled in the GrumPHP configuration.

See: phpro/grumphp#865
ashokadewit pushed a commit to mediact/testing-suite that referenced this issue Aug 20, 2021
To replace the Symfony Security Checker, the Enlightn Security
Checker has been installed, which does the same checks and is
already enabled in the GrumPHP configuration.

See: phpro/grumphp#865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants