Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All security checkers you ever needed #873

Merged
merged 5 commits into from
Feb 4, 2021

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Feb 3, 2021

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets #865, #870, #871

This PR adds support for 3 new security checkers in a BC safe way:

  • fabpot-local
  • symfony security:check
  • enligthn

@veewee veewee added this to the 1.3.1 milestone Feb 3, 2021
@veewee
Copy link
Contributor Author

veewee commented Feb 3, 2021

@paras-malhotra / @JeppeKnockaert / : I provided an alternative solution. Can you take a look at this approach? Thanks!

I'll give it a second review tomorrow, since I'm looking at the screen for a long time now :)

@paras-malhotra
Copy link
Contributor

Looking great @veewee! 👍

Gotta admit the title of this PR is humorous 😄

@cerw
Copy link

cerw commented Feb 4, 2021

Please merge, we need it :) thanks

@veewee
Copy link
Contributor Author

veewee commented Feb 4, 2021

It's coming up today @cerw ... Give me some time. Thanks for the patience!

@cerw
Copy link

cerw commented Feb 4, 2021

@veewee Amazing! thanks

@veewee veewee merged commit e5e2d61 into phpro:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants