Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SensioLabs Security Checker with CLI tool #871

Closed
wants to merge 1 commit into from
Closed

Replace SensioLabs Security Checker with CLI tool #871

wants to merge 1 commit into from

Conversation

JeppeKnockaert
Copy link
Contributor

@JeppeKnockaert JeppeKnockaert commented Jan 28, 2021

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Documented? yes
Fixed tickets #865

This PR replaces sensiolabs/security-checker (which will be abandoned at the end of January) and replaces it by fabpot/local-php-security-checker (as recommended by sensiolabs/security-checker in their readme).

@paras-malhotra
Copy link
Contributor

paras-malhotra commented Jan 28, 2021

@JeppeKnockaert, the advantage of #870 over this PR is licensing. The fabpot/local-php-security checker is licensed under AGPL (different from the sensiolabs/security-checker that was licensed under MIT). It is difficult to pull in AGPL licensed stuff in many projects. Note that AGPL is the strictest GPL license, more restrictive than GPLv3. The enlightn/security-checker is MIT.

@JeppeKnockaert
Copy link
Contributor Author

Good point, I'll close this one in favour of yours! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants