Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound/music feedback #328

Closed
KatieWoe opened this issue Jan 11, 2023 · 9 comments
Closed

Sound/music feedback #328

KatieWoe opened this issue Jan 11, 2023 · 9 comments
Assignees
Labels
type:question Further information is requested

Comments

@KatieWoe
Copy link

Test device
Dell
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#879
Not really a bug, but I'll admit I'm having trouble connecting the sounds/music to the shapes/properties in my head. I'm not sure how to look for bugs effectively since I'm having trouble understanding what it is meant to sound like. This may just be me though.

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Quadrilateral‬
URL: https://phet-dev.colorado.edu/html/quadrilateral/1.0.0-dev.73/phet/quadrilateral_all_phet.html
Version: 1.0.0-dev.73 2023-01-08 23:48:12 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36
Language: en-US
Window: 1280x649
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe KatieWoe added the type:question Further information is requested label Jan 11, 2023
@KatieWoe
Copy link
Author

I'm also having more trouble understanding the "one unique sound per detected shape" option. For instance, the concave and convex quadrilaterals sound the same to me in this option.

@jessegreenberg
Copy link
Contributor

I think this is good feedback for us to review but I am not sure what (if anything) we should do about it now. Sounds are not really changeable at this point. But maybe we could provide a little more context in Preferences Dialog or in teacher materials or something.

@BLFiedler do you have any thoughts?

@KatieWoe
Copy link
Author

It may also just be a learning style/individual thing. If it makes sense to others, it may just be how my brain works?

@KatieWoe
Copy link
Author

Further commentary:

Kathryn Woessner
[3:08 PM]
This may be a stupid question, but are the layered sound and the unique sound per shape options switched? I noticed that if you make a triangle, there is no sound that plays in the default option but there is in the second option. That seems a bit backwards, but like I said I'm having trouble understanding the sounds anyway.
Jesse Greenberg
[3:14 PM]
Not a stupid Question but I don't think so because the current set up was reviewed by the design team. It's a good thought though can you put that comment about triangle and why it feels backwards in the issue?

It sounded backwards to me since there were more sounds in the non-layered version than the layered version.

@terracoda
Copy link
Contributor

terracoda commented Jan 16, 2023

Hey @BLFiedler, did we ever try 1 single sound for each shape?

I am wondering, given the names of the radio buttons if it would make sense from a sound design/learning experience perspective to play a single sound for each shape. Then there would be a built-in way to learn what each sound meant? Just an idea.

Currently, with radio button number 2, "Sounds emphasize independent shapes", it's like each shape has a unique song or tune. Are the combinations random?

Did we ever try the single-sound approach? Would that make for a weird/unhelpful learning experience?

Or would it simplify the sound design, and support the layered option at the same time?

@brettfiedler
Copy link
Member

brettfiedler commented Jan 19, 2023

I'm open to that change to a single track per shape. I can "see" the difficulty in auditorily distinguishing tracks very quickly. It will likely take some effort to further distinguish shapes with any amount of backing tracks happening. This will, of course, simplify implementation for this sound design.

@jessegreenberg, go ahead and

  • Remove the de-emphasized tracks that play behind each shape's mapped track. Each track should only have the track mapped to it playing. Triangle should be silent like in the layered design. Let's have the track volume set to the same level as the layers maximum.

If it makes sense to simplify the file structure because of this change, go ahead.

Tagging #175 as this change will impact tasks there (and possibly negate them).

@jessegreenberg
Copy link
Contributor

Done above, I think. I kind of liked having a mode where all sounds played at once, sad to see it go. Differences between the other sound design may be more difficult to hear now. If you would like to try a happy medium where background sounds still play but more quietly you can adjust this value to be between 0 and 1. Prior to this change it was 0.15.

// First, reduce all the sound clips output
this.soundClips.forEach( soundClip => {
soundClip.setOutputLevel( 0 );
} );

Over to @BLFiedler to review and play with output levels or just close.

jessegreenberg added a commit that referenced this issue Jan 19, 2023
@brettfiedler
Copy link
Member

Yeah, I do agree 😕 . I'll spend a little bit of time with it tomorrow.

@brettfiedler
Copy link
Member

Alright, I feel the problem actually has more to do with the track selection after some time spent with it. I've made some modifications. I'd like to request a few individual volume tweaks, but I'll do that back in the original issue (#175). Hopefully, the contrast between shapes has improved here. I removed some of the more repetitious high-pitched tracks which I think dominated the background.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants