Skip to content

Commit

Permalink
reduce output of background sounds for the emphasis design, see #328
Browse files Browse the repository at this point in the history
  • Loading branch information
jessegreenberg committed Jan 19, 2023
1 parent 5ba6ea8 commit b9afcc7
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions js/quadrilateral/view/sound/TracksVolumeEmphasisSoundView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
* design.
*
* TODO: This will be renamed once a name is decided in https://github.com/phetsims/quadrilateral/issues/248
* TODO: After https://github.com/phetsims/quadrilateral/issues/328, a single sound is played, this is no longer a layer
* of sound.
*
* @author Jesse Greenberg (PhET Interactive Simulations)
*/
Expand Down Expand Up @@ -79,9 +81,9 @@ class TracksVolumeEmphasisSoundView extends TracksSoundView {

const shapeNameListener = ( shapeName: NamedQuadrilateral ) => {

// First, reduce all the sound clips to a background output level
// First, reduce all the sound clips output
this.soundClips.forEach( soundClip => {
soundClip.setOutputLevel( 0.15 );
soundClip.setOutputLevel( 0 );
} );

const tracksToEmphasize = NAMED_QUADRILATERAL_TO_HIGH_VOLUME_TRACKS_MAP.get( shapeName );
Expand Down

0 comments on commit b9afcc7

Please sign in to comment.