-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferences Menu - Sound Design Section #282
Comments
Sounds great. Let's largely plan on implementing your Iteration 2, but let's chat about it briefly in Description meeting this week so I understand where each of those suggestions go and to refine our language around each sound design. |
@terracoda , what about something like this for the visuals? |
Yep that looks good and maybe the following Context Responses when things are toggled on and off: Context responses for radio buttons (we might not need these responses):
Context responses for checkbox:
|
@BLFiedler, is this issue ready for @jessegreenberg (or you) for implementation? |
I feel like the placeholder text will be a distraction for the QA team so I am going to do this quickly now. |
This was done. @BLFiedler @terracoda can you please review the new visual text and layout? @terracoda can you please review the Voicing for this content? I wasn't sure how to do the radio buttons, have we done Voicing for radio buttons before? If so, can you point me to an example? If not, when would you like name/object/context/hint responses be triggered from various input? |
Name Responses and Context Responses for radio buttons...
@BLFiedler. Maybe we may only need a Name Response for these radio buttons? The text on the screen can just identify the selected design. Radio buttons are activated on focus/click. Do you think of these names accurately communicate the selected sound design?:
The Play Forever check box...
Checkbox design:
Over to you @BLFiedler for some thoughts on polishing the visual text and the responses. |
@jessegreenberg, also to note, the radio buttons in RaP have context responses, but their actual name responses are very short. Let's see if these Preferences radio buttons will sound ok with only name responses. |
These changes were made in the above commits. @terracoda can you please review? A couple of questions, which we started to discuss over slack.
|
Great Questions Jesse. Re Q2 - default voicing pattern for checkboxes Re Q1 - I think we need a change that simplifies things Using an on-off switch for "Play shape sounds forever" would make this entire UI way simpler. Also, I am thinking people would more more likely to want to play sounds forever before potentially changing the sound design. I am going to propose something different and simpler. With this design, "Shape Sound Options" can follow the Preferences Menu reading-block pattern. And the context responses for the on-off switch would be:
We can leave it to the leaner to figure out that Shape Sounds has to be checked in the sim for this to take effect. |
I'm good with the changes proposed by @terracoda! |
Sorry, I am not sure. I really like this proposed design though! It was done in the above commits. Can you please review? |
Seems like this is working nicely. |
Great, thanks! @terracoda will continue to review but this is no longer blocking test. |
I found a navigation glitch with the Shape Sound Options radio buttons. The sim crashed. I have to re-load to check on those :-) |
The voicing is working great, and so is everything else. I needed to clear my cache. |
Related to #248, Cleaning up the Preferences Dialog, we need Voicing Design a for both the "Sound Design" section under Sounds in the Audio tab, and "Fine Input Spacing" under the Simulation tab.
I'll create 2 issues, this one is for the section "Sound Design" which currently has 2 radio buttons and a checkbox.
Iteration 1
I sketched out a voicing design for iteration 1 in the design document
I suggest we discuss Iteration 2.
Iteration 2
Section heading for radio buttons and checkbox:
Help text options for radio buttons:
Help text options for BOTH radio buttons AND checkbox:
Names for radio buttons:
Context responses for radio buttons:
The checkbox for "Tracks play forever" is trickier.
I also considered a Shape Sound Duration (AB switch), but we do not have a design pattern for an A-B switch. It might be easy, but I have not thought about that aspect of an A-B switch. It might work as a toggle button with 2 names under the hood, not sure.
The text was updated successfully, but these errors were encountered: