Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voicing doesn't read Shape Sound radio buttons with mouse #321

Closed
Nancy-Salpepi opened this issue Jan 10, 2023 · 3 comments
Closed

Voicing doesn't read Shape Sound radio buttons with mouse #321

Nancy-Salpepi opened this issue Jan 10, 2023 · 3 comments
Assignees
Labels

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
13.1

Browser
safari 16.1 and chrome

Problem description
For phetsims/qa#879, Voicing will not read the Shape Sound Options when clicked on with the mouse. It only reads them with keyboard nav.

Steps to reproduce

  1. Turn on Voicing
  2. Click on the Shape Sound Options radio buttons

Visuals

quadShapePreferences.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Quadrilateral‬ URL: https://phet-dev.colorado.edu/html/quadrilateral/1.0.0-dev.73/phet/quadrilateral_all_phet.html Version: 1.0.0-dev.73 2023-01-08 23:48:12 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.2 Safari/605.1.15 Language: en-US Window: 1399x710 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@jessegreenberg
Copy link
Contributor

jessegreenberg commented Jan 10, 2023

Great, thanks @Nancy-Salpepi! Related to #282, the Voicing content for these buttons was meant to be filled in there.

On hold until design questions are answered there.

@brettfiedler
Copy link
Member

Assigning @terracoda to review and close when #282 is complete

@jessegreenberg
Copy link
Contributor

This is a subset of #282 now, the Voicing for these buttons will be reviewed by @terracoda there. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants