Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REVIEW comments #225

Closed
pixelzoom opened this issue Mar 4, 2024 · 3 comments
Closed

REVIEW comments #225

pixelzoom opened this issue Mar 4, 2024 · 3 comments
Assignees
@matthew-blackman
Labels
dev:code-review

Comments

@pixelzoom
Copy link
Contributor

For code review #32 ...

This issue is a catch-all for commiting REVIEW comment, and for any misc changes that I might make.

I'll assign this issue to @samreid and @matthew-blackman when I've completed the review.
@pixelzoom pixelzoom self-assigned this Mar 4, 2024
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
add doc to nested code that was a bit confusing
d663ba1
pixelzoom added a commit that referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #225
8042b77
@samreid
Copy link
Member

samreid commented Mar 4, 2024

I'm planning to address a few of the REVIEW issues that have already been written. Co-assigning for now.

@samreid samreid self-assigned this Mar 4, 2024
samreid added a commit that referenced this issue Mar 4, 2024
@samreid
Add ZoomLevel type alias, see #225
756d41f
samreid added a commit that referenced this issue Mar 4, 2024
@samreid
Update documentation, see #225
da6290d
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
HistogramNode constructor should be protected, #32
97d0b29
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #32
dfb337f
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #32
ea5927f
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #32
44df743
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #32
10c0ea5
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #32
ce4fe63
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #32
7c8143c
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #32
c0697f1
pixelzoom referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #32
3bf681e
@pixelzoom
Copy link
Contributor Author

I have completed review comments, search for "REVIEW". Over to @matthew-blackman and @samreid.

pixelzoom added a commit that referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #225
a4626c4
pixelzoom added a commit that referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #225
376e5e2
pixelzoom added a commit that referenced this issue Mar 4, 2024
@pixelzoom
REVIEW comments, #225
081bcf8
matthew-blackman added a commit that referenced this issue Mar 6, 2024
@matthew-blackman
Address REVIEW comments - see #225
9d7ceac
samreid added a commit that referenced this issue Mar 6, 2024
@samreid
Address REVIEW comments, see #225
68ba6b0
@samreid samreid removed their assignment Mar 6, 2024
matthew-blackman added a commit that referenced this issue Mar 7, 2024
@matthew-blackman
Address REVIEW comments - see #225
2e47aea
matthew-blackman added a commit that referenced this issue Mar 7, 2024
@matthew-blackman
Add documentation, address REVIEW comments - see #225
44a50e3
matthew-blackman added a commit that referenced this issue Mar 7, 2024
@matthew-blackman
Address REVIEW comments - see #225
054eb10
samreid added a commit that referenced this issue Mar 7, 2024
@samreid
Convert exports to public static readonly attributes, see #225
2de1ceb
samreid added a commit to phetsims/scenery that referenced this issue Mar 7, 2024
@samreid
Move documentation from optionize call site to the declaration of the…
bfee694 
… options type, see phetsims/projectile-data-lab#225
samreid added a commit that referenced this issue Mar 7, 2024
@samreid
Move documentation from optionize call site to the declaration of the…
bd002c2 
… options type, see #225
@matthew-blackman
Copy link
Contributor

All review comments have been addressed. Nice work @samreid and thanks for the recommendations @pixelzoom. This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-blackman matthew-blackman

Labels
dev:code-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @pixelzoom @matthew-blackman